Skip to content

More updates to Tau NN [14_0_0_pre3]#1214

Merged
aloeliger merged 4 commits intocms-l1t-offline:phase2-l1t-integration-14_0_0_pre3from
Duchstf:TauSpring2024
Mar 5, 2024
Merged

More updates to Tau NN [14_0_0_pre3]#1214
aloeliger merged 4 commits intocms-l1t-offline:phase2-l1t-integration-14_0_0_pre3from
Duchstf:TauSpring2024

Conversation

@Duchstf
Copy link

@Duchstf Duchstf commented Feb 28, 2024

PR description:

This PR is to update some fixes in the Tau NN that was merged in cms-sw#43639. In particular, the input types were changed to ap_fixed<16,6> which introduced in-consistency in performance in CMSSW as compared to python simulation.

PR validation:

  • Codes compiled, and formatted.
  • Performance was checked by making various performance plots:

image

@Duchstf Duchstf changed the title More updates to Tau NN and Tau GT integration More updates to Tau NN [14_0_0_pre3] Feb 29, 2024
@EmyrClement
Copy link

For reference, here's the same matching efficiency plot before this PR.

image

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -j 8

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 check-headers

@triggerDoctor
Copy link

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

  • L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc

Please run scram b code-format to auto-apply code formatting

Info Value
return code 0
command eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

@Duchstf
Copy link
Author

Duchstf commented Mar 4, 2024

Hmm I don't think this L1Trigger/L1TMuon/src/MicroGMTConfiguration.cc is related to any changes I made.

@epalencia
Copy link

Yes, that is correct. Do not worry about it.

@aloeliger aloeliger added Phase-2 Pertains to phase-2 development Algorithm Development labels Mar 5, 2024
@aloeliger
Copy link

@epalencia I don't think I have any review here. Would you be okay with just merging this and starting the PR to CMSSW?

@aloeliger
Copy link

@Duchstf This is being merged to provide validation material for the menu team. If there is no PR open to main CMSSW for this PR, please do so immediately. @epalencia FYI.

@aloeliger aloeliger merged commit ad34fea into cms-l1t-offline:phase2-l1t-integration-14_0_0_pre3 Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Algorithm Development Phase-2 Pertains to phase-2 development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments