Update to PuppiTau with pT calibration [13_3_0_pre3] [Merged in central CMSSW]

[Duchstf]

PR description:

Update to PuppiTauNN with pT calibrations, making the PR here as recommended as well, for more details please visit: cms-sw#43639

The performance is documented in this talk here: https://indico.cern.ch/event/1321399/#17-phase-2-nn-puppi-taus

All codes compile, passed tests in central CMSSW CI, and we verified that the outputs are the same as the NN we implemented in Python (by @andrzejnovak):

l1ct::PFTau.passLooseNN() is again what people should use for studies.

[epalencia]

@Duchstf, this PR has 30 modified files while the one in master has 29, is it because of the different releases?

[Duchstf]

@epalencia oh no, I actually added a minor correction to the working point of the NN in this file:

https://github.com/cms-l1t-offline/cmssw/pull/1202/files#diff-1194e2aafd6ecf87da700631ba27cb1f104228e8a16370ce256a3971c49d25e1

Otherwise everything stay the same, I'll make another PR correcting this in the central PR.

[epalencia]

Would it make sense to remove that from here so we have a 1 to 1 correspondence?

[Duchstf]

@epalencia I think it would make more sense to add the same changes to central CMSSW.

[epalencia]

Yes, that for sure. We will have 2 PRs in master, that is why I thought having 2 PRs in the IB might make things more straight forward. I'll not insist, it is not so important.

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

Attempts to compile this PR succeeded!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -j 8

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found no issues with the code checks!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-checks && scram b -k -j 8 code-checks

I found no issues with the headers!

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 check-headers

[triggerDoctor]

Hello, I'm triggerDoctor. @aloeliger is testing this script for L1T offline software validation.

I found 1 files that did not meet formatting requirements:

• L1Trigger/L1TTrackMatch/plugins/L1TrackJetClustering.h

Please run scram b code-format to auto-apply code formatting

Info	Value
return code	0
command	eval scramv1 runtime -sh && scram b -k -j 8 code-format-all

[epalencia]

@Duchstf , could you open a PR in master for the correction to the working point of the NN implemented here?

[EmyrClement]

Can I check what we should do here? I believe that as the equivalent PR to master is merged and available in the new base branch for this PR, the only change that is now required is a few lines of changes to update the working point, in both the IB and in master?

[epalencia]

I think that is correct. Only this commit ab00ed9 is needed in this PR and in another one to CMSSW. The other two are already merged in master and included in this new 14_0_0_pre3 branch

[EmyrClement]

@Duchstf in that case, can you either rebase this PR to the new base branch, which should just effectively leave the commit mentioned by Enrique? Or if it's easier, open a new PR with just the one commit that updated the working point?

[epalencia]

@Duchstf , could you open a PR in master for the correction to the working point of the NN implemented here?

[aloeliger]

Hi @Duchstf, I'm going around starting to figure out how to update all PRs to our new IB

For this PR I would recommend:

1. First, make a backup of this branch and it's commits pushed to github under a different name
2. checkout CMSSW_14_0_0_pre3 via cmsrel CMSSW_14_0_0_pre3 && cd CMSSW_14_0_0_pre3/src/ && cmsenv && git cms-init
3. Get a copy of this branch locally via git cms-checkout-topic -u Duchstf:puppitau_pt_13_3_0_pre3
4. Perform an interactive rebase via git rebase from-CMSSW_14_0_0_pre3 --interactive
5. In the interactive rebase, please drop all commits that were not originally part of this pull request. In my tests, there seemed to be some earlier commits from track trigger commits that get caught up in this somehow?
6. You can either then push the resulting branch to the current PR branch, or make a new one and make a PR from that branch to cms-l1t-offline:phase2-l1t-integration-14_0_0_pre3

Alternatively, because you have relatively few commits, you could just cherry-pick commits by doing something like:

1. First, make a backup of this branch and it's commits pushed to github under a different name
2. checkout CMSSW_14_0_0_pre3 via cmsrel CMSSW_14_0_0_pre3 && cd CMSSW_14_0_0_pre3/src/ && cmsenv && git cms-init
3. Fetch your changes git fetch my-cmssw
4. Cherry pick the 4 necessary commits via git cherry-pick, the 3 commands needed (in order) I think are: git cherry-pick ab0960a0f5e22f844e1d6d04a5dd96a7d3d21fed git cherry-pick e1128b41429a4a8496e6a89aa405ca7d2a3b4098 and git cherry-pick ab00ed9eeda5b3c077c72e5d5181eb6dbb699fc7
5. You can either then push the resulting branch to the current PR branch, or make a new one and make a PR from that branch to cms-l1t-offline:phase2-l1t-integration-14_0_0_pre3

[EmyrClement]

@Duchstf can this PR be closed now? Effectively the only remaining change introduced by this PR is implemented in #1214 (updating the WP)