Skip to content

fix:Phase2 onnx model with added Softmax layer#69

Merged
cmsbuild merged 2 commits intocms-data:masterfrom
uttiyasarkar:master
Jun 10, 2025
Merged

fix:Phase2 onnx model with added Softmax layer#69
cmsbuild merged 2 commits intocms-data:masterfrom
uttiyasarkar:master

Conversation

@uttiyasarkar
Copy link
Contributor

Following the presentation in HLT upgrade meeting here dated 03.06.2025, we spotted a bug on the current Phase-2 DeepJet model for b-tagging here.
It has a missing Softmax layer which makes the final DeepJet scores wrong.
The issue has been addressed and the model is modified with the additional Softmax step in the correct place. This model is validated and results are shown in the above mentioned presentation.

This PR includes:

  • The fixed DeepJet onnx model with Softmax layer included.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2025

A new Pull Request was created by @uttiyasarkar for branch master.

@akritkbehera, @cmsbuild, @iarspider, @jfernan2, @mandrenguyen, @smuzaffar can you please review it and eventually sign? Thanks.
@antoniovilela, @mandrenguyen, @rappoccio, @sextonkennedy you are the release manager for this.
cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2025

cms-bot internal usage

@mmusich
Copy link

mmusich commented Jun 6, 2025

@uttiyasarkar

IIUC the file RecoBTag/Combined/data/DeepFlavourV02_PhaseII/DeepJet_retraining_phase2_new_inputs.onnx is bugged.
I think we should remove it from the release. Do you agree?

@rovere @VourMa

@uttiyasarkar
Copy link
Contributor Author

Okay I agree

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

Pull request #69 was updated.

@mmusich
Copy link

mmusich commented Jun 6, 2025

test parameters:

@mmusich
Copy link

mmusich commented Jun 6, 2025

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2025

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-39e327/46578/summary.html
COMMIT: c11f17c
CMSSW: CMSSW_15_1_X_2025-06-06-1100/el8_amd64_gcc12
Additional Tests: HLT_P2_INTEGRATION
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-data/RecoBTag-Combined/69/46578/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 3 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 4073530
  • DQMHistoTests: Total failures: 83
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 4073427
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 218 log files, 186 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 5 / 49 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2025

REMINDER @rappoccio, @sextonkennedy, @antoniovilela, @mandrenguyen: This PR was tested with cms-sw/cmssw#48256, please check if they should be merged together

@mmusich
Copy link

mmusich commented Jun 9, 2025

type bug-fix

@mandrenguyen
Copy link
Contributor

+1

@mandrenguyen
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit bf37a42 into cms-data:master Jun 10, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants