Updated ROOT geometry version compatibility #48288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ROOT versions < 6.37.0 use GetGeomPainter() while newer versions use GetGeomChecker() for geometry overlap checks.
Contributor
|
cms-bot internal usage |
Contributor
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48288/45133 Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
Contributor
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48288/45134 |
Contributor
|
A new Pull Request was created by @akritkbehera for master. It involves the following packages:
@Dr15Jones, @alja, @cmsbuild, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Contributor
Author
|
Please test |
Contributor
|
+1 |
cmsbuild
added
visualization-approved
fully-signed
and removed
visualization-pending
pending-signatures
labels
Contributor
|
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2) |
Contributor
|
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals |
Contributor
|
please test lets rerun tests |
Contributor
|
-1 Failed Tests: RelVals The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: RelVals |
Contributor
|
I would assume this external needs to be included?: cms-data/RecoBTag-Combined#69 |
Contributor
ah ok, lets retest once a new IB with the data external is available |
Contributor
|
please test newer IB with the needed external is now available |
Contributor
|
REMINDER @mandrenguyen, @rappoccio, @antoniovilela, @sextonkennedy: This PR was tested with cms-sw/cmsdist#9917, please check if they should be merged together |
Contributor
|
+1 Size: This PR adds an extra 28KB to repository Comparison SummarySummary:
|
Contributor
|
@cms-sw/orp-l2 , can you please review this and merge it? This is needed to get the ROOT6 updates cms-sw/cmsdist#9917 |
Contributor
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROOT geometry version compatibility
Update geometry checker/painter calls for ROOT 6.37+ compatibility.
ROOT versions < 6.37.0 use GetGeomPainter() while newer versions
use GetGeomChecker().