Add fill description for PFCandidateFwdPtrProducer #48884

stahlleiton · 2025-09-10T04:49:09Z

PR description:

This PR adds a fill description for PFCandidateFwdPtrProducer

@Moanwar @yongbinfeng

PR validation:

Checked locally that the configuration is created

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild · 2025-09-10T04:49:39Z

cms-bot internal usage

cmsbuild · 2025-09-10T04:51:50Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48884/46041

cmsbuild · 2025-09-10T04:52:12Z

A new Pull Request was created by @stahlleiton for master.

It involves the following packages:

CommonTools/UtilAlgos (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@ftenchini, @mandrenguyen, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

Martin-Grunewald · 2025-09-10T06:47:30Z

CommonTools/UtilAlgos/interface/FwdPtrProducer.h

+      if (std::is_same<reco::PFCandidate, T>::value)
+        ps.add<edm::InputTag>("src", {"particleFlowTmp"});
+      else
+        ps.add<edm::InputTag>("src");


Please put a default also here, even if empty (ie, "").
ConfDB parsing requires a value, otherwise the parameter will not exist in ConfDb where we keep the HLT menus!

I don't quite understand why we need to make reco::PFCandidate a special case. I would just supply a generic empty string in all cases.

Ok, I can do it for all cases. Thought we wanted to have one fill description specifically for the PF case

Thought we wanted to have one fill description specifically for the PF case

This came into the context of a specific template specification involving PF because it's the only module of this type used in the HLT (which cares the most about this feature), but I really don't see the point of not making it general as you are touching the code.

done, I updated the PR as suggested

cmsbuild · 2025-09-10T06:57:17Z

Milestone for this pull request has been moved to CMSSW_16_0_X. Please open a backport if it should also go in to CMSSW_15_1_X.

jfernan2 · 2025-09-10T08:51:09Z

please test

cmsbuild · 2025-09-11T03:51:14Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48884/46054

cmsbuild · 2025-09-11T07:11:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-48884/46056

cmsbuild · 2025-09-11T07:11:39Z

Pull request #48884 was updated. @cmsbuild, @jfernan2, @mandrenguyen can you please check and sign again.

jfernan2 · 2025-09-11T07:22:08Z

please test

cmsbuild · 2025-09-11T08:17:54Z

-1

Failed Tests: RelVals
Size: This PR adds an extra 20KB to repository
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d5dbae/48055/summary.html
COMMIT: 6a768a9
CMSSW: CMSSW_16_0_X_2025-09-10-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

29634.75

----- Begin Fatal Exception 11-Sep-2025 09:57:34 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT_VALIDATION.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29634.75_TTbar_14TeV+Run4D110_HLT75e33Timing


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1170): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1394): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

29834.999

----- Begin Fatal Exception 11-Sep-2025 10:02:40 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step3_DIGI_DATAMIX_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/29834.999_TTbar_14TeV+Run4D110PU_PMXS1S2PR


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1170): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1394): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

24834.911

----- Begin Fatal Exception 11-Sep-2025 10:01:57 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_DIGI_L1TrackTrigger_L1_L1P2GT_DIGI2RAW_HLT.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file L1Trigger/Phase2L1ParticleFlow/data/met/l1met_ptphi2pxpy_poly2_v1.json anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/48884/48055/CMSSW_16_0_X_2025-09-10-2300/external/el8_amd64_gcc12/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw-patch/CMSSW_16_0_X_2025-09-10-2300/external/el8_amd64_gcc12/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/24834.911_TTbar_14TeV+Run4D98_DD4hep


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Types.py(1050): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(398): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Mixins.py(533): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Modules.py(160): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1170): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02906/el8_amd64_gcc12/cms/cmssw/CMSSW_16_0_X_2025-09-10-1100/src/FWCore/ParameterSet/python/Config.py(1394): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

mandrenguyen · 2025-09-11T08:38:21Z

ignore tests-rejected with ib-failure
Failures are coming from here

jfernan2 · 2025-09-11T08:42:45Z

+1

cmsbuild · 2025-09-11T08:43:07Z

This pull request is fully signed and it will be integrated in one of the next master IBs (test failures were overridden). This pull request will now be reviewed by the release team before it's merged. @ftenchini, @sextonkennedy, @mandrenguyen (and backports should be raised in the release meeting by the corresponding L2)

mandrenguyen · 2025-09-11T18:02:09Z

+1

cmsbuild added this to the CMSSW_15_1_X milestone Sep 10, 2025

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending code-checks-pending labels Sep 10, 2025

stahlleiton mentioned this pull request Sep 10, 2025

Modules not auto-generating a cfi file in cfi-python currently present in the HLT menu (Run 3 and Phase 2) #47275

Open

49 tasks

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 10, 2025

Martin-Grunewald reviewed Sep 10, 2025

View reviewed changes

cmsbuild modified the milestones: CMSSW_15_1_X, CMSSW_16_0_X Sep 10, 2025

cmsbuild added tests-started tests-pending and removed tests-pending tests-started labels Sep 10, 2025

stahlleiton force-pushed the PF_CMSSW_15_1_X branch from 4482228 to f76206f Compare September 11, 2025 03:49

cmsbuild added code-checks-pending and removed code-checks-approved labels Sep 11, 2025

cmsbuild removed the code-checks-pending label Sep 11, 2025

Add fill description for PFCandidateFwdPtrProducer

6a768a9

stahlleiton force-pushed the PF_CMSSW_15_1_X branch from f76206f to 6a768a9 Compare September 11, 2025 07:09

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Sep 11, 2025

cmsbuild added code-checks-approved and removed code-checks-pending labels Sep 11, 2025

cmsbuild added tests-started and removed tests-pending labels Sep 11, 2025

cmsbuild added tests-rejected and removed tests-started labels Sep 11, 2025

cmsbuild added tests-approved tests-ib-failure and removed tests-rejected labels Sep 11, 2025

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels Sep 11, 2025

cmsbuild added orp-approved and removed orp-pending labels Sep 11, 2025

cmsbuild merged commit ba2e15e into cms-sw:master Sep 11, 2025
9 of 10 checks passed

Add fill description for PFCandidateFwdPtrProducer #48884

Add fill description for PFCandidateFwdPtrProducer #48884

Uh oh!

Conversation

stahlleiton commented Sep 10, 2025

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Uh oh!

cmsbuild commented Sep 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cmsbuild commented Sep 10, 2025

Uh oh!

cmsbuild commented Sep 10, 2025

Uh oh!

Martin-Grunewald Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

stahlleiton Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

mmusich Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

stahlleiton Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

cmsbuild commented Sep 10, 2025

Uh oh!

jfernan2 commented Sep 10, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

jfernan2 commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

RelVals

Uh oh!

mandrenguyen commented Sep 11, 2025

Uh oh!

jfernan2 commented Sep 11, 2025

Uh oh!

cmsbuild commented Sep 11, 2025

Uh oh!

mandrenguyen commented Sep 11, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

cmsbuild commented Sep 10, 2025 •

edited

Loading