Fix sp2memwriter #376
Merged
Fix sp2memwriter #376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug that occurred on the 2nd event if a tf_mem_bin module is written to the same clock cycle sync_nent goes high. If this happened, the binmask wouldn't be completely cleared for the next BX, and TrackletProcessors would then read stale data. There exists a guard against this for normal BX transitions, however this guard wasn't used during the very first BX transition (when sync_nent goes high).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some bugs in
sp2_mem_writer.vhdthat caused discrepancies between EMP and standalone simulation/emulation, specificallyAlso added logic to propagate EMP reset to SectorProcessor
Remaining simulation discrepancies seem to just result from extra truncation caused by EMP input (this will be changed when links go to 360 MHz anyway).
These changes were added on top of PR #375.