-
Notifications
You must be signed in to change notification settings - Fork 25
Debug printout #373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Debug printout #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not to be written in the next event written to same page
Merged
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
reviewed
Sep 24, 2025
aehart
approved these changes
Sep 30, 2025
Contributor
aehart
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and it should now automatically merge once the CI tests finish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes how we write the debug output. Instead of using the FileWriter and FileWriterFIFO modules that run "in parallel" with the memory modules when writing to the memories the file printing functionality has been moved to the memory modules. As the memory modules had evolved to keep track of the addresses being written to the logic for the debug memories had become very complicated and not useful as a debugging tool. This new code attempts to address this.