Change/fix implementation of TrackletConfigBuilder to simplify logic … #339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomalin
reviewed
Nov 19, 2025
| //Now handle the AS memories used by the TrackletProcessors. Original code tried to implement | ||
| //this algorithmically, but logic got super confusing so now rewritten using a 'table' of the TPs | ||
|
|
||
| std::vector<std::pair<std::string, std::pair<std::string, std::vector<std::string> > > > TPs = { |
Collaborator
There was a problem hiding this comment.
Why is this not part of the wiring map created by L1TrackConfigBuilder? If we really need this huge table here, then please add big comment explaining how this table was producer, so people know how & when to modify it in future.
Collaborator
|
This fails git CI, because tracking efficiency too low etc. My PR #334 changed the definitions of tracking performance, but also adjusted git CI thresholds so CI still passed. My PR was merged on Oct. 12. You could trying rebasing in case this explains the poor tracking performance of your PR. but I suspect your PR may genuinely be giving reduced tracking performance. |
Collaborator
|
Given that Thomas Schuh's big PR has just been merged, your PR needs rebasing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
Change/fix implementation of TrackletConfigBuilder to simplify logic and unintended routing for L1L2 seeding.
PR validation:
Have run tracking on 200PU and seen good tracking efficiency