Skip to content

docs(governance): gate implementation on merged intent PR - #137

Merged
bouillipx merged 7 commits into
mainfrom
opt_todo_rule
Mar 2, 2026
Merged

docs(governance): gate implementation on merged intent PR#137
bouillipx merged 7 commits into
mainfrom
opt_todo_rule

Conversation

@bouillipx

Copy link
Copy Markdown
Collaborator

Summary

This PR adds an explicit docs-only intent PR gate before implementation starts.

The repository already has Claim Ledger to reserve TODO scope. This change adds the missing visibility gate:

  • claim locally is not enough
  • spec-sync locally is not enough
  • execution board locally is not enough
  • implementation may start only after a docs-only spec-sync / intent PR is merged into main

Key Changes

  • define a two-layer collaboration model
    • outer layer: Claim Ledger for TODO scope ownership
    • inner layer: per-change execution board for work packages, Gates, and touch scope
  • require intent PR merge before implementation
  • clarify when an execution board is required
  • sync workflow skills with the same rule

Updated Files

  • docs/guides/Documentation_First_Development_SOP.md
  • docs/todos/README.md
  • docs/todos/templates/change_execution_todo_template.md
  • docs/guides/Development_Constraints.md
  • docs/guides/Team_Agent_Collab_Playbook.md
  • .codex/skills/development-workflow/SKILL.md
  • .codex/skills/spec-driven-collab-board/SKILL.md

New Workflow

  1. Finish analysis and master TODO
  2. Write Claim Ledger
  3. Create/update OpenSpec change
  4. Create/update execution board if needed
  5. Open docs-only intent PR
  6. Merge intent PR into main
  7. Start implementation and open impl PR

For high-conflict changes, the flow can be:

intent PR -> Gate freeze PR -> impl PR

Notes

  • keeps the existing Claim Ledger model from main
  • does not overwrite the current AgentScope active claim board on main
  • adds execution-board layering and the implementation gate on top

Verification

  • git diff --check origin/main...HEAD
  • ./scripts/ci/check_governance_evidence_truth.sh

Reviewer Checklist

Please review this PR mainly as a governance / workflow change.

1. Rule Coherence

  • Claim Ledger is still the outer ownership layer
  • execution board is clearly defined as the inner coordination layer
  • the responsibilities of TODO_INDEX, project_overall_todos, and per-change execution boards are no longer ambiguous

2. New Gate

  • the docs-only intent PR gate is clearly stated
  • the rule is explicit that implementation cannot start before intent PR is merged into main
  • the rule does not require code to be bundled into the intent PR

3. Practicality

  • the workflow is still usable for a 3-4 person team
  • low-conflict / single-owner changes are not forced into unnecessary execution boards
  • high-conflict changes can still split into intent PR -> Gate freeze PR -> impl PR

4. Skill Alignment

  • development-workflow reflects the same gate order as the governance docs
  • spec-driven-collab-board reflects the same outer/inner board model
  • there is no contradiction between docs and skills

5. Merge Safety

  • this PR does not overwrite the current active AgentScope board already in use on main
  • this PR extends the current Claim Ledger model rather than replacing it
  • no unrelated governance behavior was changed

6. Acceptance Question

  • after reading this PR, is the answer to “when can implementation begin?” unambiguous?

Define a clear three-layer collaboration model for spec-driven work by separating design backlog, project roadmap, and active change execution boards.

Add explicit work-package guidance with Gate-based freezing rules, ownership fields, and status flow so high-speed parallel development can scale without turning project-level TODOs into contention points.

Add a reusable execution-board template and a collaboration design note, then migrate the existing AgentScope execution TODO into the standardized sample format while preserving its technical task content and dependency model.

Keep AGENTS.md out of this commit so the documentation governance changes remain isolated from unrelated workspace edits.
Create a temporary local backup commit for the current uncommitted workspace changes so opt_todo_rule can be safely rebased onto the latest origin/main.

This commit intentionally captures the in-progress AGENTS.md edit and the newly added step-driven execution-board docs as a local preservation point only.

The goal is to avoid losing working tree state while updating the branch against the latest remote main for change-selection review.
Add a repo-local skill that standardizes how spec-driven collaborative execution boards are created, refreshed, and downgraded.

Remove the earlier trial step-driven active board artifacts so this branch no longer carries a concrete execution-board rollout. The branch now keeps only the reusable skill, leaving real board creation as a later explicit action.

Verification: git diff --cached --check
Add an explicit docs-only intent PR gate between claim/spec-sync and implementation.

Clarify the two-layer collaboration model across governance docs: the outer Claim Ledger reserves TODO scope, while per-change execution boards coordinate work packages, Gate freezes, and touch scope inside an active change.

Sync the development-workflow and spec-driven-collab-board skills so they require ownership declaration, determine when an execution board is needed, and block implementation until the docs-only intent PR is merged into main.

Verification: git diff --check for updated governance docs and skills.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9c204d85ff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread AGENTS.md Outdated
@bouillipx

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

https://github.com/zts212653/Deterministic-Agent-Runtime-Engine/blob/9c204d85ffad3678b78de75e5e7f99e52547b610/docs/guides/Team_Agent_Collab_Playbook.md#L15-L16
P2 Badge Use repo-relative doc paths in the collaboration playbook

The new playbook hard-codes references like /Users/lysander/projects/dare-framework/..., which only resolve on one specific workstation. For everyone else (including CI and other contributors), these links are broken, so the governance sources this document points to become non-discoverable and easy to misapply. Replace these with repository-relative paths (for example docs/agent_rules.md, .github/workflows/ci-gate.yml) to keep the guidance portable.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/todos/templates/change_execution_todo_template.md
Fix three review findings from PR #137.

Replace the AGENTS bootstrap text with a valid skill instruction instead of a nonexistent shell command. Convert workstation-specific collaboration playbook references to repo-relative paths so the links remain portable for other contributors and CI. Add the missing Gate-4 definition to the execution-board template so the sample work-package freeze gate matches the declared gate summary.

Verification: git diff --check for updated files.
@bouillipx

Copy link
Copy Markdown
Collaborator Author

Addressed the latest review feedback in 7f66efe.

Updated:

  • AGENTS.md: replaced the nonexistent using superpowers bootstrap command with a valid using-superpowers skill instruction.
  • docs/guides/Team_Agent_Collab_Playbook.md: converted workstation-specific absolute doc/workflow references to repo-relative paths.
  • docs/todos/templates/change_execution_todo_template.md: added the missing Gate-4 definition so the gate summary matches the WP-D freeze gate.

Verification:

  • git diff --check -- AGENTS.md docs/guides/Team_Agent_Collab_Playbook.md docs/todos/templates/change_execution_todo_template.md

Remove the repo-level AGENTS bootstrap block that instructed agents to use the local superpowers workflow.

This bootstrap is environment-specific and should stay in the local setup rather than being committed into the shared repository. The rest of the governance and collaboration changes remain unchanged.

Verification: git diff --check -- AGENTS.md
@bouillipx

Copy link
Copy Markdown
Collaborator Author

Updated in 6f9e899:

  • Removed the superpowers bootstrap block from AGENTS.md.
  • That workflow is local-only and should not live in the shared repository.

This keeps the PR focused on the governance / intent-PR workflow changes while leaving local agent bootstrap out of repo state.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 6f9e899b6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@@ -0,0 +1,82 @@
# AgentScope Execution Board Migration Implementation Plan

> **For Claude:** REQUIRED SUB-SKILL: Use superpowers:executing-plans to implement this plan task-by-task.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove unavailable required sub-skill from migration plan

This plan is currently not executable as written because it makes superpowers:executing-plans mandatory, but that skill is not present in this repository’s skill catalog (checked .codex/skills/). Any agent that follows this “REQUIRED SUB-SKILL” instruction will fail before doing the migration work, so the plan should reference an available skill or provide a valid fallback path.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in c956932. Removed the hard dependency on superpowers:executing-plans and replaced it with repository-available workflow guidance so the migration plan does not assume local-only skills.

Comment thread docs/plans/2026-02-28-spec-driven-collaboration-granularity-design.md Outdated
Address the remaining review feedback in PR #137.

Remove the migration plan's hard dependency on a local superpowers skill and replace it with repository-available workflow guidance. Update the collaboration granularity design to reflect the current governance model: Claim Ledger is the outer ownership record, execution boards are the inner coordination layer, and docs-only intent PRs gate implementation.

Verification: git diff --check for updated plan files.
@bouillipx
bouillipx merged commit bfce6b9 into main Mar 2, 2026
8 checks passed
@bouillipx
bouillipx deleted the opt_todo_rule branch March 2, 2026 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant