[common] Filter seed by features supported. #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
from
4272bd8 to
623b4c8
Compare
vincenzopalazzo
commented
Oct 8, 2021
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
from
623b4c8 to
7440a40
Compare
cloudhead
reviewed
Oct 10, 2021
cloudhead
reviewed
Oct 10, 2021
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
from
2c2bd89 to
173fb35
Compare
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
6 times, most recently
from
e6eaca9 to
3cb277a
Compare
|
If you give me the ack on this PR I will squash the commit it only one and I will change the comment message with a better description, to avoid closing the PR and open another one, if you agree. |
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
3 times, most recently
from
0de2c42 to
0727274
Compare
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
3 times, most recently
from
9f8968f to
d217041
Compare
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
from
d217041 to
d6f3e2b
Compare
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
from
d6f3e2b to
8c6e7c3
Compare
This include a rework of the PR cloudhead#54, but not include the refactoring in other module. Signed-off-by: Vincenzo Palazzo <[email protected]>
The following commit include the combination of the two flags, but the resolution has the following result on mainet
```
2021-10-10T10:11:46.433+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.bitcoin.sipa.be", 8333)
2021-10-10T10:11:46.790+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:46.790+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.dnsseed.bluematt.me", 8333)
2021-10-10T10:11:47.409+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:47.409+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.dnsseed.bitcoin.dashjr.org", 8333)
2021-10-10T10:11:47.612+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:47.612+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.bitcoinstats.com", 8333)
2021-10-10T10:11:47.664+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.bitcoin.jonasschnelli.ch", 8333)
2021-10-10T10:11:47.920+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:47.920+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.btc.petertodd.org", 8333)
2021-10-10T10:11:47.959+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:47.959+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.bitcoin.sprovoost.nl", 8333)
2021-10-10T10:11:48.086+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:48.086+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.dnsseed.emzy.de", 8333)
2021-10-10T10:11:49.048+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:49.048+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.bitcoin.wiz.biz", 8333)
2021-10-10T10:11:49.828+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
2021-10-10T10:11:49.828+02:00 DEBUG nakamoto_common::p2p::peer Resolving DNS seed ("x41.seed.cloudhead.io", 8333)
2021-10-10T10:11:49.908+02:00 DEBUG nakamoto_common::p2p::peer Error received is failed to lookup address information: Name or service not known
```
In case of resolution failure, we need also to check the single feature here in some order of importance for nakamoto?
Signed-off-by: Vincenzo Palazzo <[email protected]>
Adding some rules on the vector of seed returned by the network. Signed-off-by: Vincenzo Palazzo <[email protected]>
…one. Signed-off-by: Vincenzo Palazzo <[email protected]>
Signed-off-by: Vincenzo Palazzo <[email protected]>
vincenzopalazzo
force-pushed
the
vincenzopalazzo/filter_dns2
branch
from
8c6e7c3 to
eb5b360
Compare
vincenzopalazzo
commented
Dec 7, 2021
Comment on lines
+54
to
+55
| while let Some(seed) = seeds.next() { | ||
| debug!("Resolving DNS seed {:?}", seed); |
There was a problem hiding this comment.
I think this PR it is not completed, because I'm missing the services flag that it is Supported by the network
Here there is still the services flag none, and this it wrong I think
match seed.to_socket_addrs() {
Ok(addrs) => {
success = true;
for addr in addrs {
self.insert(
addr.ip(),
KnownAddress::new(
Address::new(&addr, ServiceFlags::NONE),
source,
None,
),
);
}
Maybe this solution proposed is totally wrong because I'm missing the services flag in the address. Mh!
|
This required another iteration, closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a rework of the PR #54, but does not include the refactoring in another module.
Closing #54
Fixes #50
Signed-off-by: Vincenzo Palazzo [email protected]