Filtering DNS seed by features

[vincenzopalazzo]

Fixes #50

Working in progress

• Refactoring all the logic inside a dns module (a better name can be seeds module?)
• Check Who support what
• Unit testing
• Put inside the node client

[cloudhead]

How about struct SeedServices { flags: bitcoin::ServiceFlags }

[vincenzopalazzo]

I think, much better, thank to point me to this feature of rust-bitcoin

[cloudhead]

For PRs I tend to prefer as minimal a diff as possible, as it makes it easier for me to review. Eg. I don't want to have to re-review my own code. So I'd suggest not moving existing code around.

[vincenzopalazzo]

Thanks for clarifying this @cloudhead, in other words, do you want that I put the check of sub-seed in the nakamoto_comm::network?

I usually maintain the code struct of the repository, and I'm sorry if I move your code out of your class, but I did that because I think have a DNS seed module makes easy future change.

BTW, if you want I can revert the change

[cloudhead]

Thanks for clarifying this @cloudhead, in other words, do you want that I put the check of sub-seed in the nakamoto_comm::network?

Yes, whatever results in the smallest diff.

I usually maintain the code struct of the repository, and I'm sorry if I move your code out of your class, but I did that because I think have a DNS seed module makes easy future change.

BTW, if you want I can revert the change

Yeah, that would be better for now. It makes my job easier to review code when less of it changes :)
It's okay if doing that means that some code is not in the optimal place. This is something that can be changed later on.

Generally, I try to not mix code refactors with change in functionality, as you have to then review two things at once.

[vincenzopalazzo]

Generally, I try to not mix code refactors with change in functionality, as you have to then review two things at once.

I agree with your point of view, thanks. I will change this PR, or close it and open a new one with the change in the nakamoto_comm::network, thanks

[vincenzopalazzo]

Closing in favor of #59