Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update node:net to enable mongodb and mysql usage #3340

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented Jan 15, 2025

Co-authored-by: @vicb

This enables the usage of mongodb and mysql in workerd. mysql package is still not supported but this unblocks several errors.

[wrangler:inf] GET / 200 OK (436ms)
before mongo
listDocuments
Connected to MongoDB
Documents:
{
  _id: new ObjectId('6787f5abdbedb3f0a155db7d'),
  name: 'Alice',
  age: 30
}
{ _id: new ObjectId('6787f5abdbedb3f0a155db7e'), name: 'Bob', age: 25 }
{
  _id: new ObjectId('6787f5abdbedb3f0a155db7f'),
  name: 'Charlie',
  age: 35
}
finally
after mongo
[wrangler:inf] GET /favicon.ico 200 OK (87ms)

@anonrig anonrig requested a review from jasnell January 15, 2025 17:58
@anonrig anonrig requested review from a team as code owners January 15, 2025 17:58
@anonrig anonrig requested a review from hoodmane January 15, 2025 17:58
@anonrig anonrig force-pushed the yagiz/update-node-net-for-mongodb branch from fbc513d to e1f5348 Compare January 15, 2025 18:05
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the test added back and revised.

@anonrig anonrig force-pushed the yagiz/update-node-net-for-mongodb branch from e1f5348 to 0c01e65 Compare January 16, 2025 15:23
@anonrig anonrig enabled auto-merge (squash) January 16, 2025 15:23
@anonrig anonrig force-pushed the yagiz/update-node-net-for-mongodb branch from 0c01e65 to 4926077 Compare January 16, 2025 15:24
@anonrig anonrig merged commit c2a6323 into main Jan 16, 2025
15 checks passed
@anonrig anonrig deleted the yagiz/update-node-net-for-mongodb branch January 16, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants