update node:net to enable mongodb and mysql usage (#3340)

Co-authored-by: Victor Berchet <[email protected]>

src/node/net.ts

@@ -769,11 +769,13 @@ Socket.prototype.setNoDelay = function (
 
 Socket.prototype.setKeepAlive = function (
   this: SocketClass,
-  enable?: boolean,
+  _enable?: boolean,
   _initialDelay?: number
 ): SocketClass {
-  if (!enable) return this;
-  throw new ERR_INVALID_ARG_VALUE('enable', enable, 'is not supported');
+  // Ignore this for now.
+  // This is used by services like mySQL.
+  // TODO(soon): Investigate supporting this.
+  return this;
 };
 
 // @ts-expect-error TS2322 Intentionally no-op
@@ -960,13 +962,9 @@ function initializeConnection(
   let { port = 0 } = options;
 
   if (autoSelectFamily != null) {
-    // We don't support this option. If the value is falsy, we can safely ignore it.
-    // If the value is truthy, we'll throw an error.
-    throw new ERR_INVALID_ARG_VALUE(
-      'options.autoSelectFamily',
-      autoSelectFamily,
-      'is not supported'
-    );
+    // We don't support this option.
+    // We shouldn't throw this because services like mongodb depends on it.
+    // TODO(soon): Investigate supporting this.
   }
 
   if (typeof port !== 'number' && typeof port !== 'string') {

src/workerd/api/node/tests/net-nodejs-test.js

@@ -443,10 +443,12 @@ export const testNetConnectImmediateFinish = {
 // something different than the original Node.js test
 export const testNetConnectKeepAlive = {
   async test() {
+    // Test that setKeepAlive call does not throw.
     throws(() => new net.Socket({ keepAlive: true }));
     const c = new net.Socket();
     c.setKeepAlive(false);
-    throws(() => c.setKeepAlive(true));
+    c.setKeepAlive(true);
+    // throws(() => c.setKeepAlive(true));
   },
 };