update v8 to 12.4 #2005
Merged
update v8 to 12.4 #2005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
reviewed
Apr 10, 2024
|
Looks like this is failing because the bazel rule for building torque is not working properly – perhaps https://chromium-review.googlesource.com/c/v8/v8/+/5339896 is responsible – not changing |
|
@garrettgu10 for the patch to be applied make sure to add it to the list of v8 patches in WORKSPACE. |
garrettgu10
force-pushed
the
ggu/v8-12.4
branch
2 times, most recently
from
1be3908 to
35dea06
Compare
garrettgu10
force-pushed
the
ggu/v8-12.4
branch
from
35dea06 to
0842e5e
Compare
garrettgu10
force-pushed
the
ggu/v8-12.4
branch
from
867fa5f to
f1d81e2
Compare
jasnell
approved these changes
Apr 29, 2024
garrettgu10
added a commit
that referenced
this pull request
May 13, 2024
Co-authored-by: James M Snell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.