Skip to content

Commit 1be3908

Browse files
committed
Add patch to edit v8root in defs.bzl
1 parent 9913f3e commit 1be3908

3 files changed

Lines changed: 23 additions & 1 deletion

File tree

.vscode/settings.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
{
22
"files.exclude": {
3-
"bazel-*": true
43
},
54
"files.insertFinalNewline": true,
65
"files.trimTrailingWhitespace": true,

WORKSPACE

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -449,6 +449,7 @@ http_archive(
449449
"//:patches/v8/0012-Always-enable-continuation-preserved-data-in-the-bui.patch",
450450
"//:patches/v8/0013-increase-visibility-of-virtual-method.patch",
451451
"//:patches/v8/0014-Add-ValueSerializer-SetTreatFunctionsAsHostObjects.patch",
452+
"//:patches/v8/0015-Set-torque-generator-path-to-external-v8.-This-allow.patch"
452453
],
453454
integrity = "sha256-C6bsXXbKgeCxmG1VNO/LScaPq0HVlmofpVHJ5kswoLg=",
454455
strip_prefix = "v8-12.4.254.11",
Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
From 73ad7c7d3b3ff45b835ffba9eb97c6a0ca13deb9 Mon Sep 17 00:00:00 2001
2+
From: Garrett Gu <garrett@cloudflare.com>
3+
Date: Wed, 10 Apr 2024 14:31:33 -0500
4+
Subject: Set torque generator path to external/v8. This allows bazel to find
5+
the generated torque outputs even though we are building from a different
6+
workspace.
7+
8+
See https://chromium-review.googlesource.com/c/v8/v8/+/5339896
9+
10+
diff --git a/bazel/defs.bzl b/bazel/defs.bzl
11+
index e55defede9fed3eea9348bd7bd50d98f688a2a7b..faeef2b2ed71b4784050451a61a16febbd7455b8 100644
12+
--- a/bazel/defs.bzl
13+
+++ b/bazel/defs.bzl
14+
@@ -347,7 +347,7 @@ def get_cfg():
15+
# split the set of outputs by using OutputGroupInfo, that way we do not need to
16+
# run the torque generator twice.
17+
def _torque_files_impl(ctx):
18+
- v8root = "."
19+
+ v8root = "external/v8"
20+
21+
# Arguments
22+
args = []

0 commit comments

Comments
 (0)