Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about wrong rate() usage even without metadata #1206

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Warn about wrong rate() usage even without metadata #1206

merged 1 commit into from
Nov 28, 2024

Conversation

prymitive
Copy link
Collaborator

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request was validated by pint.

✔️ No problems found

Stats

Stat Value
Version v0.67.3-46-g00e292a
Number of rules parsed 4
Number of rules checked 4
Number of problems found 0
Number of offline checks 0
Number of online checks 0
Checks duration 0

Problems

No problems reported

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 92.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.98%. Comparing base (0fea32c) to head (00e292a).

Files with missing lines Patch % Lines
internal/checks/promql_rate.go 92.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1206      +/-   ##
==========================================
- Coverage   94.99%   94.98%   -0.02%     
==========================================
  Files         104      103       -1     
  Lines       12561    12530      -31     
==========================================
- Hits        11932    11901      -31     
+ Misses        480      479       -1     
- Partials      149      150       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Benchmark diff:

goos: linux
goarch: amd64
pkg: github.com/cloudflare/pint/cmd/pint
cpu: AMD EPYC 7763 64-Core Processor                
              │   old.txt   │              new.txt               │
              │   sec/op    │   sec/op     vs base               │
FindEntries-4   39.85m ± 1%   39.94m ± 1%       ~ (p=0.105 n=10)
CheckRules-4     8.524 ± 2%    8.515 ± 2%       ~ (p=0.684 n=10)
geomean         582.8m        583.2m       +0.07%

              │   old.txt    │               new.txt               │
              │     B/op     │     B/op      vs base               │
FindEntries-4   27.40Mi ± 0%   27.40Mi ± 0%       ~ (p=0.896 n=10)
CheckRules-4    974.8Mi ± 0%   974.3Mi ± 0%       ~ (p=0.853 n=10)
geomean         163.4Mi        163.4Mi       -0.02%

              │   old.txt   │              new.txt               │
              │  allocs/op  │  allocs/op   vs base               │
FindEntries-4   131.7k ± 0%   131.7k ± 0%       ~ (p=0.781 n=10)
CheckRules-4    14.14M ± 0%   14.14M ± 0%       ~ (p=0.912 n=10)
geomean         1.365M        1.364M       -0.01%

@prymitive prymitive merged commit aeb0788 into main Nov 28, 2024
20 checks passed
@prymitive prymitive deleted the rate branch November 28, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants