Unify VDAF dispatching logic #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjpatton
requested review from
armfazh,
bhalleycf,
fisherdarling,
cbranch,
lbaquerofierro,
mendess,
RageKnify and
jhoyla
as code owners
cjpatton
force-pushed
the
cjpatton/698-vdaf-dispatch
branch
from
d290a79 to
4d3dd54
Compare
Add dispatchers for sharding, preparation, and unsharding to `VdafConfig`. Pass the DAP version to the dispatcher so that we can properly resolve supported VDAFs. Remove support for the following, unspecified combinations: * DAP-13/Pine32HmacSha256Aes128 * DAP-13/Pine64HmacSha256Aes128 * DAP-09/Mastic Technically, since Mastic is still a shim at the moment and not a functional VDAF, we could support it in DAP-09 as well. When the implementation is complete (divviup/libprio-rs#947), it will only be VDAF-13-compatible and thus only supported in DAP-13.
cjpatton
force-pushed
the
cjpatton/698-2-dispatcher
branch
from
658902e to
ba7d9b3
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #698.
Stacked on #749.
Add dispatchers for sharding, preparation, and unsharding to
VdafConfig. Pass the DAP version to the dispatcher so that we can properly resolve supported VDAFs.Remove support for the following, unspecified combinations:
Technically, since Mastic is still a shim at the moment and not a functional VDAF, we could support it in DAP-09 as well. When the implementation is complete (divviup/libprio-rs#947), it will only be VDAF-13-compatible and thus only supported in DAP-13.