Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vdaf: Isolate prio_draft09 usage as much as possible #751

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

cjpatton
Copy link
Contributor

Partially addresses #698.
Stacked on #750.

Move some methods from the base of the module to where they're used. This reduces the number of trait collisions there.

Copy link
Collaborator

@mendess mendess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but left a nit pick

crates/daphne/src/vdaf/prio3_draft09.rs Outdated Show resolved Hide resolved
@cjpatton cjpatton force-pushed the cjpatton/698-3-prio3-draf09-cleanup branch from b2741f4 to 6e4b5d6 Compare December 20, 2024 15:47
@cjpatton cjpatton force-pushed the cjpatton/698-2-dispatcher branch from 658902e to ba7d9b3 Compare December 20, 2024 15:50
Base automatically changed from cjpatton/698-2-dispatcher to main December 20, 2024 16:03
Move some methods from the base of the module to where they're used.
This reduces the number of trait collisions there.

Also, rename `prio3_draft09` to `draft09`, as the same code is shared by
`pine`.
@cjpatton cjpatton force-pushed the cjpatton/698-3-prio3-draf09-cleanup branch from 6e4b5d6 to 9c79654 Compare December 20, 2024 16:04
@cjpatton
Copy link
Contributor Author

Rebased.

@cjpatton cjpatton merged commit e46b0f9 into main Dec 20, 2024
3 checks passed
@cjpatton cjpatton deleted the cjpatton/698-3-prio3-draf09-cleanup branch December 20, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants