lots of outstanding changes #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After running stack solver, the following changes were made: removed: safe-exceptions-0.1.1.0 added: swagger2-2.1.4.1 http-media-0.7.1.1
...in preparation to ghcjs client side library, which we do not want to burden with inappropriate dependencies such as wai.
Owner
|
Review status: 0 of 25 files reviewed at latest revision, all discussions resolved. Comments from Reviewable |
...since xhr requests are always in the same host
...otherwise warp `setOnException` does not work
they use hspec-wai which has no exception handling logic and thus exceptions just crash. moreover, `error` out in the monad rather than in the response in the tests for the router, since warp just sends empty responses when the response itself contains errors.
bitonic
force-pushed
the
francesco
branch
2 times, most recently
from
320b783 to
30472ac
Compare
...this allows, for example, to plumb in `AbortController`s more easily.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is