disable 500 tests for now in solga-client tests

they use hspec-wai which has no exception handling logic and thus
exceptions just crash.

moreover, `error` out in the monad rather than in the response in the
tests for the router, since warp just sends empty responses when the
response itself contains errors.

Author: bitonic

solga-client/test/Test.hs

@@ -47,7 +47,7 @@ testAPI :: TestAPI
 testAPI = TestAPI
   { basic = brief (return "basic")
   , echoJSON = brief return
-  , internalError = brief (return $ error "quality programming")
+  , internalError = brief (error "quality programming")
   , echoCapture = brief return
   }
 
@@ -82,7 +82,7 @@ spec port = do
 
   -- tests exception handling
   describe "GET /fubar" $ do
-    it "responds with 500" $
+    it "responds with 500" $ do
       req port $ choose internalError $ GetResponse $ \resp _ ->
         Http.responseStatus resp `shouldBe` status500
 

solga-router/test/Test.hs

@@ -36,7 +36,6 @@ main = hspec spec
 data TestAPI = TestAPI
   { basic :: "basic" /> Get T.Text
   , echoJSON :: "echo-json" /> ReqBodyJSON Value :> Post Value
-  , internalError :: "fubar" /> Get T.Text
   , echoCapture :: "echo-capture" /> Capture T.Text :> Get T.Text
   } deriving (Generic)
 instance Router TestAPI
@@ -45,7 +44,6 @@ testAPI :: TestAPI
 testAPI = TestAPI
   { basic = brief (return "basic")
   , echoJSON = brief return
-  , internalError = brief (return $ error "quality programming")
   , echoCapture = brief return
   }
 
@@ -79,11 +77,6 @@ spec = with (return $ serve testAPI) $ do
       resp <- post "/echo-json" (encode val)
       liftIO $ decode (simpleBody resp) `shouldBe` Just (val :: Value)
 
-  -- tests exception handling
-  describe "GET /fubar" $ do
-    it "responds with 500" $
-      get "/fubar" `shouldRespondWith` 500
-
   -- tests Capture
   describe "GET /echo-capture" $ do
     it "responds with 200" $