Prepare the receiver for self-sent messages with empty To field #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Delta Chat is going to send self-sent messages with undisclosed recipients instead of placing self into the `To` field. To avoid assigning broadcast list messages to Saved Messages chat, we should check the mailing list headers before attempting to assign to Saved Messages.
link2xt
force-pushed
the
link2xt/putnmwzpnlpp
branch
2 times, most recently
from
ee6ec9c to
b9aa5e4
Compare
link2xt
changed the title
Currently Delta Chat puts self address in the To field to avoid the To field being empty. There is a plan to put empty `hidden-recipients` group there, this fix prepares the receiver for such messages.
Previously such messages were assigned to trash.
link2xt
force-pushed
the
link2xt/putnmwzpnlpp
branch
from
68a9863 to
57e0b5b
Compare
If message has empty `To` field it is a self-sent message like a message in Saved Messages chat or a sync message.
iequidoo
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation PR for #6401. Currently Delta Chat puts self address in the
Tofield when there are no other recipients, e.g. in Saved Messages chat or in "member removed" message deleting the last member. I want to change this to send emptyhidden-recipientsgroup instead like some clients do when there are only Bcc recipients or like we already do for broadcast lists. Currently Delta Chat assigns such messages to trash unless they are broadcast list messages, this PR fixes this with a test.