feat: add support for tokio #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows configuration of either tokio or async-std. Drops support for `socks5` with `async-std`, as the underlying library `fast-sockst5` has done so in the latest release.
|
So how are we going to use async-smtp in delta chat now? We use socks5 there. |
I am working on switching DC to tokio |
Why? Not against it, just don't know what's the difference and first time I hear you are working on it. Seems most libraries (sqlx, async-native-tls) support multiple runtimes now. fast-socks5 PR for reference: dizda/fast-socks5#9 |
link2xt
approved these changes
Jun 22, 2022
| } | ||
| } | ||
|
|
||
| /// Execute io operations with an optional timeout using. |
There was a problem hiding this comment.
Copy-pasted comment: "using" what?
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 22, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
2 tasks
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 23, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 24, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
dignifiedquire
added a commit
to chatmail/core
that referenced
this pull request
Jun 27, 2022
depends on - [ ] chatmail/async-smtp#52 - [ ] chatmail/async-imap#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows configuration of either tokio or async-std.
Drops support for
socks5withasync-std, as the underlying libraryfast-socks5has done so in the latest release.Closes #13