Skip to content

Conversation

@JuxhinDB
Copy link

@JuxhinDB JuxhinDB commented Jun 6, 2022

Updating nom to latest version as it's causing build errors in twistrs. Tests are passing bar one, however it seems to be related to some missing file/config.

test result: ok. 25 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/transport_file.rs (target/debug/deps/transport_file-4c3d8b1858f4d79e)

running 1 test
test test::file_transport ... ok

test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

     Running tests/transport_sendmail.rs (target/debug/deps/transport_sendmail-35c9ebf37f972ebe)

running 1 test
test test::sendmail_transport_simple ... FAILED

failures:

---- test::sendmail_transport_simple stdout ----
Err(Io(Os { code: 2, kind: NotFound, message: "No such file or directory" }))
thread 'test::sendmail_transport_simple' panicked at 'assertion failed: result.is_ok()', tests/transport_sendmail.rs:22:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

JuxhinDB added 2 commits June 6, 2022 20:24
- Update version of nom crate;
- Update errors to match new fields.
@JuxhinDB JuxhinDB changed the title Bump nom dependency to ^0.7.0 Bump nom dependency to ^7.0 Jun 6, 2022
@link2xt
Copy link
Contributor

link2xt commented Jun 7, 2022

Tests are passing bar one, however it seems to be related to some missing file/config.

Probably you don't have sendmail installed?

@link2xt link2xt requested a review from dignifiedquire June 7, 2022 07:47
@JuxhinDB
Copy link
Author

JuxhinDB commented Jun 7, 2022

Tests are passing bar one, however it seems to be related to some missing file/config.

Probably you don't have sendmail installed?

That was it. :-)

@JuxhinDB
Copy link
Author

@link2xt Any update on merging this perhaps?

@link2xt
Copy link
Contributor

link2xt commented Jun 22, 2022

cc @dignifiedquire
Seems it is a subset of #52 now

@link2xt
Copy link
Contributor

link2xt commented Jun 27, 2022

#52 is merged

@link2xt link2xt closed this Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants