Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PLUGIN-1864] Error management for javascript transform plugin #1940

Merged
merged 1 commit into from
Feb 18, 2025
Merged

[PLUGIN-1864] Error management for javascript transform plugin #1940

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 25 additions & 10 deletions core-plugins/src/main/java/io/cdap/plugin/transform/JavaScriptTransform.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,9 @@
import io.cdap.cdap.api.annotation.Plugin;
import io.cdap.cdap.api.data.format.StructuredRecord;
import io.cdap.cdap.api.data.schema.Schema;
import io.cdap.cdap.api.exception.ErrorCategory;
import io.cdap.cdap.api.exception.ErrorType;
import io.cdap.cdap.api.exception.ErrorUtils;
import io.cdap.cdap.api.plugin.PluginConfig;
import io.cdap.cdap.etl.api.Arguments;
import io.cdap.cdap.etl.api.Emitter;
Expand Down Expand Up @@ -185,9 +188,10 @@ public void initialize(TransformContext context) throws Exception {
Class<?> somClass = Class.forName("jdk.nashorn.api.scripting.ScriptObjectMirror");
somValuesMethod = somClass.getMethod("values");
} catch (NoSuchMethodException e) {
throw new RuntimeException(
"Failed to get method ScriptObjectMirror#values() for converting ScriptObjectMirror to List. " +
"Please check your version of Nashorn is supported.", e);
String error = "Failed to get method ScriptObjectMirror#values() for converting ScriptObjectMirror to List." +
" Please check your version of Nashorn is supported.";
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.SYSTEM, false, e);
} catch (ClassNotFoundException e) {
// Ignore -- we don't have Nashorn, so no need to handle Nashorn
}
Expand All @@ -208,7 +212,9 @@ public void transform(StructuredRecord input, Emitter<StructuredRecord> emitter)
engine.put(EMITTER_NAME, jsEmitter);
invocable.invokeFunction(FUNCTION_NAME);
} catch (Exception e) {
throw new IllegalArgumentException("Could not transform input: " + e.getMessage(), e);
String error = String.format("Could not transform input: %s", e.getMessage());
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.USER, false, e);
}
}

Expand Down Expand Up @@ -265,7 +271,9 @@ private InvalidEntry<StructuredRecord> getErrorObject(Map result, StructuredReco
"errorCode must be a valid Integer");
errorCodeInt = errorCodeDouble.intValue();
} else {
throw new IllegalArgumentException("Unsupported errorCode type: " + errorCode.getClass().getName());
String error = String.format("Unsupported errorCode type: %s", errorCode.getClass().getName());
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.USER, false, null);
}
return new InvalidEntry<>(errorCodeInt, (String) result.get("errorMsg"), input);
}
Expand Down Expand Up @@ -313,8 +321,9 @@ private Object decode(Object object, Schema schema) {
case UNION:
return decodeUnion(object, schema.getUnionSchemas());
}

throw new RuntimeException("Unable decode object with schema " + schema);
String error = String.format("Unable decode object with schema %s", schema);
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.USER, false, null);
}

private StructuredRecord decodeRecord(Map nativeObject, Schema schema) {
Expand All @@ -333,7 +342,9 @@ private List jsObject2List(Object object) {
try {
return (List) somValuesMethod.invoke(object);
} catch (InvocationTargetException | IllegalAccessException | ClassCastException e) {
throw new RuntimeException("Failed to convert ScriptObjectMirror to List", e);
String error = "Failed to convert ScriptObjectMirror to List";
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.USER, false, null);
}
}
return (List) object;
Expand Down Expand Up @@ -369,7 +380,9 @@ private Object decodeSimpleType(Object object, Schema schema) {
case STRING:
return (String) object;
}
throw new RuntimeException("Unable decode object with schema " + schema);
String error = String.format("Unable decode object with schema %s", schema);
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.USER, false, null);
}

private Map<Object, Object> decodeMap(Map<Object, Object> object, Schema keySchema, Schema valSchema) {
Expand All @@ -396,7 +409,9 @@ private Object decodeUnion(Object object, List<Schema> schemas) {
// could be ok, just move on and try the next schema
}
}
throw new RuntimeException("Unable decode union with schema " + schemas);
String error = String.format("Unable decode union with schema %s", schema);
throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN),
error, error, ErrorType.USER, false, null);
}

private void init(@Nullable TransformContext context, FailureCollector collector) {
Expand Down
Loading