[PLUGIN-1864] Error management for javascript transform plugin #1940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psainics
force-pushed
the
fem/javascript-error
branch
from
881e376 to
b0f887b
Compare
| String error = "Failed to get method ScriptObjectMirror#values() for converting ScriptObjectMirror to List." + | ||
| " Please check your version of Nashorn is supported."; | ||
| throw ErrorUtils.getProgramFailureException(new ErrorCategory(ErrorCategory.ErrorCategoryEnum.PLUGIN), | ||
| error, error, ErrorType.USER, false, e); |
There was a problem hiding this comment.
should be SYSTEM error since user is not providing the method to be loaded.
itsankit-google
approved these changes
Feb 18, 2025
|
please squash commits before merge. Please remember to cherry-pick this PR in |
psainics
force-pushed
the
fem/javascript-error
branch
from
3255663 to
f8a09fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error Management for javascript transform plugin exceptions
https://cdap.atlassian.net/browse/PLUGIN-1864
Code change
Modified JavascriptTransform.java
Tests
Test Case - tested with valid script and script throwing exception
1. Valid script
2. Exception from script