[PLUGIN-1861] Error management for excel plugin #1935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
54
to
64
| return getProgramFailureException((MissingSheetException) t, errorContext, | ||
| ErrorType.USER); | ||
| } | ||
| if (t instanceof ReadException) { | ||
| return getProgramFailureException((ReadException) t, errorContext, | ||
| ErrorType.USER); | ||
| } | ||
| if (t instanceof EmptyFileException) { | ||
| return getProgramFailureException((EmptyFileException) t, errorContext, | ||
| ErrorType.USER); | ||
| } | ||
| if (t instanceof IllegalArgumentException) { |
There was a problem hiding this comment.
can we add some subCategories for these errors?
Like for IllegalArgumentException, subCategory can be Configuration.
| private static final String ERROR_MESSAGE_FORMAT = "Error occurred in the phase: '%s'. Error message: %s"; | ||
| private static final String SUBCATEGORY_CONFIGURATION = "Configuration"; | ||
| private static final String SUBCATEGORY_DATA_MISSING = "Data Missing"; | ||
| private static final String SUBCATEGORY_FILE_READ_ERROR = "File Read Error"; |
There was a problem hiding this comment.
Error sounds redundant since it is already an errorCategory.
|
|
||
| private static final String ERROR_MESSAGE_FORMAT = "Error occurred in the phase: '%s'. Error message: %s"; | ||
| private static final String SUBCATEGORY_CONFIGURATION = "Configuration"; | ||
| private static final String SUBCATEGORY_DATA_MISSING = "Data Missing"; |
There was a problem hiding this comment.
Data Integrity sounds more appropriate which can signify that required data is missing or incomplete
itsankit-google
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Error Management for argument setter exceptions
https://cdap.atlassian.net/browse/PLUGIN-1861
Code change
Modified HTTPArgumentSetter.java
Modified ArgumentSetter.java
Modified pom.xml
Tests
Test Case - tested with Incorrect json value and format
1. Success
2. Invalid Argument JSON format
3. Missing Argument JSON value