Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[PLUGIN-1861] Error management for excel plugin | RowDenormaliser" #1939

Merged

Conversation

psainics
Copy link
Contributor

@psainics psainics commented Feb 12, 2025

Our of sync pr removed these changes #1935

Origional PR #1936

  • This is only for develop branch, release branch is correctly in sync !

Description
Error Management for row denormaliser aggregator exceptions
https://cdap.atlassian.net/browse/PLUGIN-1862

Code change
Modified RowDenormalizerAggregator.java

Tests
Test Case - tested with Incorrect key, name and value field

1. Valid parameters

Screenshot 2025-01-23 at 5 47 06 PM

2. Incorrect key field

POST v3/namespaces/{namespace-id}/apps/{app-id}/workflows/DataPipelineWorkflow/runs/{run-id}/classify

[
    {
        "stageName": "RowDenormalizer",
        "errorCategory": "Plugin-\u0027RowDenormalizer\u0027",
        "errorReason": "Keyfield \u0027idrf\u0027 does not exist in input schema {\"type\":\"record\",\"name\":\"text\",\"fields\":[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"attribute\",\"type\":\"string\"},{\"name\":\"value\",\"type\":\"string\"}]}",
        "errorMessage": "Keyfield \u0027idrf\u0027 does not exist in input schema {\"type\":\"record\",\"name\":\"text\",\"fields\":[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"attribute\",\"type\":\"string\"},{\"name\":\"value\",\"type\":\"string\"}]}",
        "errorType": "USER",
        "dependency": "false"
    }
]
Screenshot 2025-01-27 at 3 51 57 PM Screenshot 2025-01-24 at 4 36 48 PM

3. Incorrect attribute field

POST v3/namespaces/{namespace-id}/apps/{app-id}/workflows/DataPipelineWorkflow/runs/{run-id}/classify

[
    {
        "stageName": "RowDenormalizer",
        "errorCategory": "Plugin-\u0027RowDenormalizer\u0027",
        "errorReason": "Namefield \u0027cdcdvdvdv\u0027 does not exist in input schema {\"type\":\"record\",\"name\":\"text\",\"fields\":[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"attribute\",\"type\":\"string\"},{\"name\":\"value\",\"type\":\"string\"}]}",
        "errorMessage": "Namefield \u0027cdcdvdvdv\u0027 does not exist in input schema {\"type\":\"record\",\"name\":\"text\",\"fields\":[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"attribute\",\"type\":\"string\"},{\"name\":\"value\",\"type\":\"string\"}]}",
        "errorType": "USER",
        "dependency": "false"
    }
]
Screenshot 2025-01-27 at 3 55 21 PM Screenshot 2025-01-24 at 4 39 39 PM

4. Incorrect value field

POST v3/namespaces/{namespace-id}/apps/{app-id}/workflows/DataPipelineWorkflow/runs/{run-id}/classify

[
    {
        "stageName": "RowDenormalizer",
        "errorCategory": "Plugin-\u0027RowDenormalizer\u0027",
        "errorReason": "Valuefield \u0027csdcdddv\u0027 does not exist in input schema {\"type\":\"record\",\"name\":\"text\",\"fields\":[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"attribute\",\"type\":\"string\"},{\"name\":\"value\",\"type\":\"string\"}]}",
        "errorMessage": "Valuefield \u0027csdcdddv\u0027 does not exist in input schema {\"type\":\"record\",\"name\":\"text\",\"fields\":[{\"name\":\"id\",\"type\":\"string\"},{\"name\":\"attribute\",\"type\":\"string\"},{\"name\":\"value\",\"type\":\"string\"}]}",
        "errorType": "USER",
        "dependency": "false"
    }
]
Screenshot 2025-01-27 at 3 57 42 PM Screenshot 2025-01-24 at 4 40 35 PM

@psainics psainics changed the title Revert "[PLUGIN-1861] Error management for excel plugin" Revert "[PLUGIN-1861] Error management for excel plugin | RowDenormaliser" Feb 12, 2025
@psainics psainics force-pushed the revert/RowDenormalizerAggregator branch from 4c960c8 to f3f39c8 Compare February 12, 2025 07:15
@psainics psainics self-assigned this Feb 12, 2025
@psainics psainics added the build Trigger unit test build label Feb 12, 2025
@psainics psainics marked this pull request as ready for review February 12, 2025 07:16
@itsankit-google itsankit-google merged commit 673c94b into cdapio:develop Feb 12, 2025
7 checks passed
@psainics psainics deleted the revert/RowDenormalizerAggregator branch February 12, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Trigger unit test build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants