Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modules): add catppuccin.sources option #129

Merged
merged 3 commits into from
May 13, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Apr 18, 2024

fixes #96. sources for each port are now exposed and configurable under catppuccin.sources for both nixos and home-manager modules.

for contributors: this replaces nvfetcher with npins as the way we manage our port sources. this was to primarily allow for user defined sources to work as expected in our modules - as unlike nvfetcher, npins is a basic name value pair of the port name and path in the store

TODO:

  • Document examples
  • Properly test
  • Allow for interop with nixpkgs' sources as suggested in Use themes from the cattpuccin package? #103 ?
    • this will be a simple PR, probably just adding their sources to passthru so they can be individually plugged in here

@getchoo getchoo marked this pull request as draft April 19, 2024 18:39
@getchoo getchoo added this to the 1.0.0 milestone Apr 30, 2024
@getchoo getchoo force-pushed the sources-option branch 4 times, most recently from c3ce53e to c94d6cb Compare May 13, 2024 19:33
@getchoo getchoo marked this pull request as ready for review May 13, 2024 19:34
getchoo added 3 commits May 13, 2024 16:30
npins gives us a nicer file to import that is a simple name value pair
of the port and the path in the store. this allows for easier overriding
with the catppuccin.sources option
@getchoo
Copy link
Member Author

getchoo commented May 13, 2024

let's hope this doesn't break something 🙃

@getchoo getchoo merged commit 28e6d8a into catppuccin:main May 13, 2024
3 checks passed
@getchoo getchoo deleted the sources-option branch May 13, 2024 20:33
Weathercold pushed a commit to Weathercold/nix that referenced this pull request May 14, 2024
* feat(modules): add `catppuccin.sources` option

* refactor(modules)!: nvfetcher -> npins

npins gives us a nicer file to import that is a simple name value pair
of the port and the path in the store. this allows for easier overriding
with the catppuccin.sources option

* fix(modules): ensure default sources are applied to `catppuccin.sources`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expose palette to lib
1 participant