feat(flake): rework theming #10
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofiedotcafe
force-pushed
the
main
branch
12 times, most recently
from
8f11397 to
398e022
Compare
sofiedotcafe
force-pushed
the
main
branch
5 times, most recently
from
d1f8ede to
67c13dd
Compare
|
Would be done in the presumably next PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think adding support for let's say
nix-colorsis bit out of line, since some stuff as for example gtk themes don't really sit with that.I could just add
nix-colorsand add their own stuff for them (like currently in the patch files) but yea...I am also waiting for catppuccin/nix#96 (and hereby catppuccin/nix#129) to progress since
catppuccin-nixhandles stuff like gtk themes thatnix-colorsdoes not. It would also be easier since I could just support all Catppuccin themes, but just not all themes?