Remove undefined constants in riscv_const.py (#2660)#2661
Merged
kabeor merged 1 commit intocapstone-engine:nextfrom Apr 2, 2025
Merged
Remove undefined constants in riscv_const.py (#2660)#2661kabeor merged 1 commit intocapstone-engine:nextfrom
kabeor merged 1 commit intocapstone-engine:nextfrom
Conversation
Rot127
requested changes
Mar 26, 2025
Collaborator
Rot127
left a comment
Rot127
left a comment
There was a problem hiding this comment.
Please remove the commented lines in riscv.h instead. And run const_generator.py python again. This will remove the constants.
The following constants are undefined in `capstone/include/capstone/riscv.h`. So, remove them as those were commented in `riscv.h`. Signed-off-by: Leon Hwang <leon.hwang@linux.dev>
Asphaltt
force-pushed
the
fix/python-binding
branch
from
14aa834 to
40869af
Compare
Asphaltt
changed the title
Rot127
approved these changes
Mar 26, 2025
Collaborator
kabeor
pushed a commit
that referenced
this pull request
Apr 9, 2025
Rot127
pushed a commit
that referenced
this pull request
Apr 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following constants are undefined in
capstone/include/capstone/riscv.h.So, comment them as those are commented in
riscv.h.Your checklist for this pull request
Detailed description
Please check the issue #2660
Test plan
I'm going to maintain gapstone, which generates Go code from
bindings/python/capstone.After fixing the
gapstone's unit test issues withcapstone5.0.6 in the future, I'll add a GitHub Actions workflow to rungo test -v .to ensure the generated Go code is fine with the correspondingcapstoneversion.Closing issues
closes #2660