fix: bring back #715 to fix Android builds for Fabric components #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serchinastico
changed the title
|
Thank you so much for the PR and sorry for the delay. I'm checking whether there is a fix without using |
atlj
approved these changes
Feb 25, 2025
There was a problem hiding this comment.
Okay I double checked the RN discord channel and according to this discussion, we can get views back to all.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I'm bringing back the fix implemented in #715. Unfortunately, it was overwritten in #721 so versions 0.48.x of create-react-native-library are failing Android builds for Fabric components.
Fixes #767