Skip to content

Commit be8b107

Browse files
fix: bring back #715 to fix Android builds for Fabric components (#769)
<!-- Please provide enough information so that others can review your pull request. --> <!-- Keep pull requests small and focused on a single change. --> ### Summary <!-- What existing problem does the pull request solve? Can you solve the issue with a different approach? --> I'm bringing back the fix implemented in #715. Unfortunately, it was overwritten in #721 so versions 0.48.x of create-react-native-library are failing Android builds for Fabric components. Fixes #767
1 parent 1684036 commit be8b107

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

packages/create-react-native-library/templates/common-local/$package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
<% if (project.arch === 'new') { -%>
77
"codegenConfig": {
88
"name": "RN<%- project.name -%><%- project.viewConfig !== null ? 'View': '' -%>Spec",
9-
"type": <%- project.viewConfig !== null ? '"components"': '"modules"' %>,
9+
"type": <%- project.viewConfig !== null ? '"all"': '"modules"' %>,
1010
"jsSrcsDir": "src"
1111
},
1212
<% } -%>

packages/create-react-native-library/templates/common/$package.json

+2-2
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@
115115
<% if (project.moduleConfig === 'nitro-modules') { -%>
116116
"react-native": "*",
117117
"react-native-nitro-modules": "^<%- versions.nitroModules %>"
118-
<% } else { -%>
118+
<% } else { -%>
119119
"react-native": "*"
120120
<% } -%>
121121
},
@@ -224,7 +224,7 @@
224224
},
225225
"codegenConfig": {
226226
"name": "RN<%- project.name -%><%- project.viewConfig !== null ? 'View': '' -%>Spec",
227-
"type": "<%- project.viewConfig !== null ? 'components': 'modules' -%>",
227+
"type": "<%- project.viewConfig !== null ? 'all': 'modules' -%>",
228228
"jsSrcsDir": "src",
229229
"outputDir": {
230230
"ios": "ios/generated",

0 commit comments

Comments
 (0)