[Improve] Show Swiss flag red background on homepage#52
Draft
roo-code-bruno[bot] wants to merge 2 commits into
Draft
[Improve] Show Swiss flag red background on homepage#52roo-code-bruno[bot] wants to merge 2 commits into
roo-code-bruno[bot] wants to merge 2 commits into
Conversation
Author
|
1 issue outstanding. Action required. See task
|
roo-code-bruno
Bot
changed the title
![roo-code-bruno[bot]](https://avatars.githubusercontent.com/u/211522643?s=60&v=4){kind=small}
| } | ||
|
|
||
| .home-page { | ||
| background-color: #da291c; |
Author
There was a problem hiding this comment.
Changing .home-page to #da291c makes the hero heading and intro copy effectively unreadable, because app/views/home/index.html.erb still renders them with text-red-600, text-gray-500, and text-gray-400 directly on the page background. Those foreground colors end up at roughly 1.0-1.9:1 contrast against the new red, so this regresses the main content on /.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Resolves the requested homepage styling change on
/so the main page background matches the Swiss flag red instead of the earlier blue follow-up color.Why this change was made
The home page background already lived in a dedicated
.home-pagestylesheet rule, so this follow-up just updates that rule to the Swiss-flag red target while keeping the generated Tailwind build output out of the change.User impact
Users now see a Swiss-red background behind the main homepage content as soon as they open the app root page.
Screenshots
Swiss-red homepage background rendered on
/.