[Docs] Require color rationale in PR descriptions#53
Draft
roo-code-bruno[bot] wants to merge 1 commit into
Draft
[Docs] Require color rationale in PR descriptions#53roo-code-bruno[bot] wants to merge 1 commit into
roo-code-bruno[bot] wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem this solves
Resolves a documentation gap where pull requests can introduce hard-coded color values without explaining why the value was chosen, which selectors it affects, or whether the affected text still meets contrast requirements.
Why this change was made
This adds a root
AGENTS.mdrule that requires PR descriptions to document hard-coded color choices with their rationale or source, the affected selectors, and a contrast confirmation. It directly addresses the review friction called out around Roo-Preview-Rails PR #52.User impact
Reviewers can assess hard-coded color changes from the PR body instead of reconstructing intent from the diff. This is a documentation-only change and does not alter runtime app behavior.