feat: Add a JS binding for MemoryPressureMonitor#118
Merged
caneraltinbasak merged 4 commits into28-x-y-bsfrom Mar 3, 2026
Merged
feat: Add a JS binding for MemoryPressureMonitor#118caneraltinbasak merged 4 commits into28-x-y-bsfrom
caneraltinbasak merged 4 commits into28-x-y-bsfrom
Conversation
caneraltinbasak
changed the title
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
from
6cb9adb to
32c4148
Compare
t-bashir-bs
reviewed
Feb 25, 2026
| ### `memoryPressureMonitor.notifyMemoryPressure(level)` | ||
|
|
||
| * `level` string - The pressure level to broadcast. Must be `moderate` or | ||
| `critical`. |
There was a problem hiding this comment.
I was wondering why notifyMemoryPressure doesn't send none as an option (i.e. if we notify the level is moderate then after the memory usage has been reduced and the pressure level goes back down to normal)?
Author
There was a problem hiding this comment.
Memory pressure handlers generally don't hold state, they apply an action. But it is a valid point, I'll address that.
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
from
32c4148 to
7c948d5
Compare
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
from
7c948d5 to
8b497fc
Compare
t-bashir-bs
reviewed
Feb 27, 2026
| * process. Chromium's internal caches, blink, and V8 will react by | ||
| * releasing memory. Respects the notification-suppressed flag. | ||
| * | ||
| * @param level - 'moderate' or 'critical' |
There was a problem hiding this comment.
This should now also include 'none'
Author
There was a problem hiding this comment.
Turns out "none" is not a valid state for MemoryPressureMonitor, there is a DCHECK which triggers if NONE is notified. Tests failed due to that. I'll remove all the changes which I've added for triggering "kNone". As I stated before MemoryPressureListeners do action, they don't hold state.
// static
void MemoryPressureListener::NotifyMemoryPressure(
MemoryPressureLevel memory_pressure_level) {
DCHECK_NE(memory_pressure_level, MEMORY_PRESSURE_LEVEL_NONE);
TRACE_EVENT_INSTANT(
trace_event::MemoryDumpManager::kTraceCategory,
"MemoryPressureListener::NotifyMemoryPressure",
[&](perfetto::EventContext ctx) {
auto* event = ctx.event<perfetto::protos::pbzero::ChromeTrackEvent>();
auto* data = event->set_chrome_memory_pressure_notification();
data->set_level(
trace_event::MemoryPressureLevelToTraceEnum(memory_pressure_level));
});
if (AreNotificationsSuppressed())
return;
DoNotifyMemoryPressure(memory_pressure_level);
}
| * | ||
| * @param level - 'moderate' or 'critical' | ||
| */ | ||
| notifyMemoryPressure (level: string): void { |
There was a problem hiding this comment.
Should have the type here?
notifyMemoryPressure (level: 'none' | 'moderate' | 'critical' )
| * Returns the current memory pressure level reported by the OS. | ||
| * @returns {'none' | 'moderate' | 'critical'} | ||
| */ | ||
| getCurrentPressureLevel (): string { |
There was a problem hiding this comment.
Should have the type here?
getCurrentPressureLevel (): 'none' | 'moderate' | 'critical' {
typings/internal-ambient.d.ts
Outdated
| createMemoryPressureMonitor(): MemoryPressureMonitorBinding; | ||
| getCurrentPressureLevel(): string; | ||
| notifyMemoryPressure(level: string): void; | ||
| emit: (event: string, ...args: any[]) => boolean; |
There was a problem hiding this comment.
Should have typing here instead of string for getCurrentPressureLevel and notifyMemoryPressure?
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
from
8b497fc to
2ef568c
Compare
t-bashir-bs
approved these changes
Mar 2, 2026
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
from
2ef568c to
da0390a
Compare
Add memoryPressureMonitor singleton for main process that wraps Chromiums memory pressure system. Enables listening for OS memory pressure events and programmatically triggering pressure notifications to force cache drops and GC. Changes: - New C++ API: shell/browser/api/electron_api_memory_pressure_monitor.* - New TypeScript wrapper: lib/browser/api/memory-pressure-monitor.ts - Methods: getCurrentPressureLevel(), notifyMemoryPressure(level) - Event: memory-pressure emitted on OS pressure changes - Tests: spec/api-memory-pressure-monitor-spec.ts - Docs: docs/api/memory-pressure-monitor.md - Registration: module-list.ts, node_bindings.cc, filenames.gni, typings
…S-20753, OS-20757 Remove IS_ANDROID guards from Chromium's cross-process memory pressure IPC to enable notifyMemoryPressure() to reach all renderer processes on all platforms via content::mojom::ChildProcess::OnMemoryPressure. Iterate RenderProcessHost instances in the browser process and forward the pressure level to each live renderer, matching the pattern used by UserLevelMemoryPressureSignalGenerator on Android.
We will use the new electron.memoryPressureMonitor to trigger memory pressure events. Electron's memoryPressureMonitor propagates events to render processes too. Remove our previous attempt where we relied on Chromium's own LinuxMemoryPressureMonitor and launching the monitor on both main and renderer processes.
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
3 times, most recently
from
ce720f2 to
107aa16
Compare
caneraltinbasak
force-pushed
the
memory-pressure-monitor-binding
branch
from
107aa16 to
08ad14d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request has 3 parts: