Skip to content

Commit ce720f2

Browse files
ci: Replace brightsign/ec2-github-runner with machulav/ec2-github-runner
Our brightsign/ec2-github-runner is too old and GitHub is refusing the connection from old client. When updating ec2-github-runner, I've noticed that there is now built in support for running the runner as service as a specified user. Instead of using our own fork, I decided to switch to using the upstream
1 parent bf68de4 commit ce720f2

1 file changed

Lines changed: 5 additions & 4 deletions

File tree

.github/workflows/bs_electron_ci_ec2.yml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ jobs:
5353
5454
- name: Start EC2 runner
5555
id: start-ec2-runner
56-
uses: brightsign/ec2-github-runner@0fa8b183dd4124fd191ccdbc48b68f0ea46a9634
56+
uses: machulav/ec2-github-runner@v2
5757
with:
5858
mode: start
5959
github-app-private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
@@ -62,7 +62,8 @@ jobs:
6262
ec2-instance-type: ${{ inputs.instance_type }}
6363
subnet-id: ${{ env.VPC_SUBNET_ID }}
6464
security-group-id: ${{ env.VPC_SG_ID }}
65-
run-as-service-with-user: ubuntu
65+
run-runner-as-service: true
66+
run-runner-as-user: ubuntu
6667
runner-home-dir: /home/ubuntu
6768
# iam-role-name: my-role-name # optional, requires additional permissions
6869
aws-resource-tags: > # optional, requires additional permissions
@@ -98,11 +99,11 @@ jobs:
9899
aws-region: ${{ inputs.aws_region }}
99100

100101
- name: Stop EC2 runner
101-
uses: brightsign/ec2-github-runner@0fa8b183dd4124fd191ccdbc48b68f0ea46a9634
102+
uses: machulav/ec2-github-runner@v2
102103
with:
103104
mode: stop
104105
github-app-private-key: ${{ secrets.GH_APP_PRIVATE_KEY }}
105106
github-app-id: 287690
106107
label: ${{ needs.start-runner.outputs.label }}
107108
ec2-instance-id: ${{ needs.start-runner.outputs.ec2-instance-id }}
108-
leave-ec2-instance-running: ${{ inputs.leave_ec2_instance_running }}
109+
leave-ec2-instance-running: ${{ inputs.leave_ec2_instance_running }}

0 commit comments

Comments
 (0)