Skip to content

fix: wp.org compliance — implicit global and handle collision in astra-notices #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rajmohanreddy774 merged 2 commits into from
May 20, 2026
Merged

fix: wp.org compliance — implicit global and handle collision in astra-notices #90

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c3424d
fix: resolve wp.org compliance issues — implicit global and handle co…
rajmohanreddy774 May 19, 2026
32b1bf8
chore: bump version to 1.2.3
rajmohanreddy774 May 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions class-bsf-admin-notices.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ class BSF_Admin_Notices {
* @var string
* @since 1.2.0
*/
private static $version = '1.2.2';
private static $version = '1.2.3';

/**
* Registered notices.
Expand Down Expand Up @@ -202,11 +202,11 @@ public function dismiss_notice() {
* @return void
*/
public function enqueue_scripts() {
wp_register_style( 'astra-notices', self::get_url() . 'notices.css', array(), self::$version );
wp_register_script( 'astra-notices', self::get_url() . 'notices.js', array( 'jquery' ), self::$version, true );
wp_register_style( 'bsf-astra-notices', self::get_url() . 'notices.css', array(), self::$version );
wp_register_script( 'bsf-astra-notices', self::get_url() . 'notices.js', array( 'jquery' ), self::$version, true );
wp_localize_script(
'astra-notices',
'astraNotices',
'bsf-astra-notices',
'bsfAstraNotices',
array(
'_notice_nonce' => wp_create_nonce( 'astra-notices' ),
)
Expand Down Expand Up @@ -328,8 +328,8 @@ public function show_notices() {
* @return void
*/
public static function markup( $notice = array() ) {
wp_enqueue_script( 'astra-notices' );
wp_enqueue_style( 'astra-notices' );
wp_enqueue_script( 'bsf-astra-notices' );
wp_enqueue_style( 'bsf-astra-notices' );

// Dual-emit: legacy (astra_notice_*) + new (bsf_admin_notice_*) hooks for backward compat.
// Note: consumers hooking BOTH names for the same event will be called twice.
Expand Down
4 changes: 2 additions & 2 deletions notices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
* @since 1.0.0
* @class ASTCustomizer
*/
AstraNotices = {
var AstraNotices = {

/**
* Initializes our custom logic for the Customizer.
Expand Down Expand Up @@ -80,7 +80,7 @@
type: 'POST',
data: {
action : 'astra-notice-dismiss',
nonce : astraNotices._notice_nonce,
nonce : bsfAstraNotices._notice_nonce,
notice_id : notice_id,
repeat_notice_after : parseInt( repeat_notice_after, 10 ),
},
Expand Down
Loading