fix: wp.org compliance — implicit global and handle collision in astra-notices#90
Merged
Merged
Conversation
kiransbsf
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
vardeclaration toAstraNotices = {→var AstraNotices = {. Without it the variable leaked into the global scope, which wp.org flags as a rejection-level issue.wp_register_script,wp_register_style,wp_enqueue_script,wp_enqueue_stylehandles fromastra-noticestobsf-astra-notices. Generic handles likeastra-noticescollide with other plugins using the same name.wp_localize_scriptobject fromastraNotices→bsfAstraNoticesand updatednotices.jsto referencebsfAstraNotices._notice_nonce. Unprefixed globals are flagged by wp.org review.astra-notice-dismiss, nonceastra-notices, CSS classes, option keys, and user meta keys are all unchanged.spectra-blockswp.org submission — this library is bundled and must pass wp.org review.Test plan
astra-notice-dismiss(Network tab) and nonce is presentwp_register_script(test alongside a plugin that usesastra-noticeshandle)phpcs --standard=phpcs.xml.dist class-bsf-admin-notices.php— no new violationsspectra-blocksbundling this lib and confirm wp.org scanner no longer flags the implicit global or handle