Skip to content

fix: use ior property instead of non-existent iorNode #1330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Feb 3, 2026
Merged

fix: use ior property instead of non-existent iorNode #1330

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/rendering/tsl/WaterMaterial.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,15 +280,16 @@

// IOR for physically-correct fresnel (water = 1.33)
// This replaces manual fresnel calculation entirely
material.iorNode = float(WATER_IOR);
// Note: ior is a regular property, not a node property
material.ior = WATER_IOR;

// Optional: slight specular tint for ocean water
material.specularColorNode = vec3(0.95, 0.97, 1.0);
// Specular intensity for water reflections
material.specularIntensity = 1.0;

Check failure on line 287 in src/rendering/tsl/WaterMaterial.ts

View workflow job for this annotation

GitHub Actions / type-check 

Property 'specularIntensity' does not exist on type 'MeshPhysicalNodeMaterial'.

// Environment map for reflections (if provided)
if (config.envMap) {
material.envMap = config.envMap;

Check failure on line 291 in src/rendering/tsl/WaterMaterial.ts

View workflow job for this annotation

GitHub Actions / type-check 

Property 'envMap' does not exist on type 'MeshPhysicalNodeMaterial'.
material.envMapIntensity = 0.8;

Check failure on line 292 in src/rendering/tsl/WaterMaterial.ts

View workflow job for this annotation

GitHub Actions / type-check 

Property 'envMapIntensity' does not exist on type 'MeshPhysicalNodeMaterial'.
}

// Opaque rendering for proper depth sorting with terrain
Expand Down
Loading