Skip to content

fix: force normal recomputation and fix material properties for decor… #1279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Feb 3, 2026
Merged

fix: force normal recomputation and fix material properties for decor… #1279

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 12 additions & 3 deletions src/rendering/InstancedDecorations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,9 +107,9 @@ function cloneGeometryForGPU(source: THREE.BufferGeometry): THREE.BufferGeometry
}

// Ensure normal coordinates exist - required for proper lighting and SSAO
// Some models from Tripo/Meshy AI lack normals, causing GTAO to reconstruct
// normals from depth gradients which creates visible triangular artifacts
if (!cloned.attributes.normal && cloned.attributes.position) {
// ALWAYS recompute normals - AI models from Tripo/Meshy often have incorrect
// or flat normals that cause dark triangular artifacts, especially with GTAO
if (cloned.attributes.position) {
cloned.computeVertexNormals();
}

Expand Down Expand Up @@ -196,6 +196,15 @@ function extractMaterial(object: THREE.Object3D, assetId?: string): THREE.Materi
// Apply rendering hints for MeshStandardMaterial
if ((material as THREE.MeshStandardMaterial).isMeshStandardMaterial) {
const stdMaterial = material as THREE.MeshStandardMaterial;

// Fix AI model artifacts - disable vertex colors and clear baked maps
// AI-generated models bake ambient occlusion into vertex colors causing triangles
stdMaterial.vertexColors = false;
stdMaterial.aoMap = null;
stdMaterial.aoMapIntensity = 0;
stdMaterial.lightMap = null;
stdMaterial.lightMapIntensity = 0;

const hints = assetId ? AssetManager.getRenderingHints(assetId) : null;

if (hints) {
Expand Down
Loading