fix: force normal recomputation and fix material properties for decor…#1279
Merged
Conversation
…ations Decorations had triangle artifacts because: 1. cloneGeometryForGPU only computed normals when missing, not forcing recomputation of bad normals from AI models 2. extractMaterial didn't apply the same fixes as AssetManager (disable vertex colors, clear aoMap/lightMap) Now decorations get the same treatment as units/buildings, ensuring proper normals and clean materials for GTAO. https://claude.ai/code/session_012kqvccEiiHNQHAjUEoposi
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ations
Decorations had triangle artifacts because:
Now decorations get the same treatment as units/buildings, ensuring proper normals and clean materials for GTAO.
https://claude.ai/code/session_012kqvccEiiHNQHAjUEoposi