Skip to content

fix(render): clone geometry buffers to prevent WebGPU disposal crash #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
braedonsaunders merged 1 commit into from
Jan 26, 2026
Merged

fix(render): clone geometry buffers to prevent WebGPU disposal crash #1054

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/rendering/compute/GPUIndirectRenderer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,14 +178,16 @@ export class GPUIndirectRenderer {
const instancedGeometry = new THREE.InstancedBufferGeometry();
instancedGeometry.instanceCount = MAX_UNITS;

// Copy attributes from source geometry
// Clone attributes from source geometry to avoid sharing disposal lifecycle.
// Setting by reference causes WebGPU "setIndexBuffer" errors when the source
// geometry is disposed elsewhere while this geometry is still in use.
for (const name of Object.keys(geometry.attributes)) {
instancedGeometry.setAttribute(name, geometry.attributes[name]);
instancedGeometry.setAttribute(name, geometry.attributes[name].clone());
}

// Copy index if present
// Clone index if present - critical to avoid shared buffer disposal issues
if (geometry.index) {
instancedGeometry.setIndex(geometry.index);
instancedGeometry.setIndex(geometry.index.clone());
}

// Create per-instance position offset attribute (vec3)
Expand Down