fix(render): clone geometry buffers to prevent WebGPU disposal crash#1054
Merged
Conversation
When creating indirect meshes, geometry attributes and index buffers were set by reference instead of being cloned. This caused a crash after ~7 minutes of gameplay when cleanup disposed shared buffers that other meshes still referenced, resulting in "setIndexBuffer: parameter 1 is not of type GPUBuffer" errors. The fix clones all geometry data so each IndirectMesh owns its own GPU buffers, allowing safe disposal without affecting the asset cache or other renderers using the same source geometry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating indirect meshes, geometry attributes and index buffers were set by reference instead of being cloned. This caused a crash after ~7 minutes of gameplay when cleanup disposed shared buffers that other meshes still referenced, resulting in "setIndexBuffer: parameter 1 is not of type GPUBuffer" errors.
The fix clones all geometry data so each IndirectMesh owns its own GPU buffers, allowing safe disposal without affecting the asset cache or other renderers using the same source geometry.