fix #12: fix terminal viewport jump during streaming#96
Open
blueberrycongee wants to merge 1 commit intomainfrom
Open
fix #12: fix terminal viewport jump during streaming#96blueberrycongee wants to merge 1 commit intomainfrom
blueberrycongee wants to merge 1 commit intomainfrom
Conversation
Monkey-patch BufferService.scroll() to freeze buffer.ydisp during buffer trimming when isUserScrolling is true. This prevents the viewport from drifting toward ydisp=0 as xterm decrements ydisp on each trimmed line. The freeze uses a temporary property descriptor so the onScroll event fires with the stable ydisp value, keeping the Viewport in sync. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BufferService.scroll()decrementsbuffer.ydispby 1 for each trimmed line during buffer trimming whileisUserScrollingis true, causing the viewport to drift towardydisp=0(stuck at top)BufferService.scroll()to freezebuffer.ydispvia a temporary property descriptor during buffer trimming whenisUserScrollingis true. The freeze blocks the trim decrement while lettingonScrollevents fire with the stable ydisp value, so the Viewport stays at the user's scroll positionscrollLines()(user-initiated scrolling) is unaffected — it's a separate code pathdocs/bugs/scroll-pinning-evolution.mdTest plan