fix #55: preserve Claude sessions across app updates#94
Open
blueberrycongee wants to merge 1 commit intomainfrom
Open
fix #55: preserve Claude sessions across app updates#94blueberrycongee wants to merge 1 commit intomainfrom
blueberrycongee wants to merge 1 commit intomainfrom
Conversation
Three changes to prevent session loss during force-kill updates: 1. Mark workspace dirty when session IDs change so auto-save persists them to disk. Previously updateTerminalSessionId did not trigger auto-save, so a force kill before manual save lost all session IDs. 2. Add session:validate IPC that checks whether a session's JSONL file still exists on disk before attempting --resume. This avoids the confusing error-then-respawn flow when Claude CLI's session data was cleaned up during an update. 3. In TerminalTile, validate sessions proactively at launch. If the session file is gone, start fresh immediately with a clear message instead of letting the CLI fail with "No conversation found".
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
updateTerminalSessionIdnow callsmarkDirty(), triggering auto-save so session IDs survive force-kill scenarios. Previously, session IDs were only persisted on explicit save or graceful quit.session:validateIPC checks whether a session's JSONL file still exists on disk before attempting--resume. If the file is gone (e.g. cleaned up by Claude CLI during update), the terminal starts fresh immediately with a clear message instead of failing with "No conversation found".Test plan