fix #13: fix update restart overlapping save-canvas dialog#89
Open
blueberrycongee wants to merge 1 commit intomainfrom
Open
fix #13: fix update restart overlapping save-canvas dialog#89blueberrycongee wants to merge 1 commit intomainfrom
blueberrycongee wants to merge 1 commit intomainfrom
Conversation
Instead of calling quitAndInstall() directly when the user clicks "Restart" (which fires app.quit() before the save dialog runs, causing UI overlap and preventing relaunch), the updater:install handler now: 1. Dismisses the update modal first 2. Triggers window.close() to go through the normal save-canvas flow 3. Sets a flag so the before-quit handler runs the install script with relaunch=true (mac) or calls quitAndInstall (win/linux) Co-Authored-By: Claude Opus 4.6 <[email protected]>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
updater:installIPC, preventing UI overlapquitAndInstall()calls withwindow.close()to go through the normal save-canvas flow first. AupdateRestartRequestedflag tells thebefore-quithandler to relaunch after installing.registerAutoInstallOnQuitnow accepts ashouldRelaunchcallback so the install script knows whether to reopen the app (user-initiated restart) or silently install (normal quit)Root cause
The
updater:installhandler calledquitAndInstall()directly, which:app.quit(), which triggered the window'sclosehandler, which showed the save dialog — overlapping with the still-visible update modalbefore-quitauto-install handler fired a second install script withrelaunch=false, racing with the first one and preventing relaunchTest plan