fix: misaligned tables #185
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After some investigation, the reason we are seeing misalignment in core in tables (to the right instead of the left) and not in deployed environments after the upgrade is an issue of CSS precedence. We currently have the desktop styles first under a media query, and then the mobile styles. The mobile styles just override the desktop ones as they come later.
However, I'm not clear why this is not a regression in Storybook. I'm wondering if there is some sort of Storybook CSS config that we just need to pull over to core?
How Can This Be Tested/Reviewed?
I used yarn link:uic locally to test out this change and ensure it works. I also checked for every other instance of a media query to see if we were inappropriately ordering the default styles after, and didn't see any other use cases.
Checklist:
Reviewer Notes:
Steps to review a PR:
On merge, squash commits.