-
Notifications
You must be signed in to change notification settings - Fork 39
feat: application create and read refactor #5701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far no issues found but I'm still testing
| }); | ||
|
|
||
| describe('submit endpoint', () => { | ||
| describe('submit endpoint with MSQ V1', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: You can do sub describes. So this could have a top-level describe('submit endpoint and then sub describes for V1 vs V2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did it this way so that when we do clean-up, we can just remove this section without having to move levels
This PR addresses #(5147)
Description
Refactors the application service create and read functions to work with the new MSQ schemas. Also improves the update function ahead of further refactor.
How Can This Be Tested/Reviewed?
Testing existing functionality:
Testing with MSQ V2:
enableV2MSQfor Bloomington/scriptRunner/migrateMultiselectDataToRefactorapplicationSelectionsfield [example body below]/applications/createExample body for the applicationsSelections field. Use prisma studio to collect the ids after running the script
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: