-
Notifications
You must be signed in to change notification settings - Fork 39
feat: geocoding refactor #5714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mcgarrye
wants to merge
21
commits into
main
Choose a base branch
from
5705/msq-refactor-geocoding-service
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: geocoding refactor #5714
+316
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ludtkemorgan
requested changes
Jan 6, 2026
Collaborator
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The true and false path look good there is just a third path that we need to figure out how to handle with this new setup
…factor-geocoding-service
✅ Deploy Preview for bloom-flagly canceled.
|
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses #(5705)
Description
Refactors the geocoding service to work with MSQ V2. The refactor allows reduced looping and requires less data be passed around.
This is pointing at PR #5701 as it follows changes to the application create function.
How Can This Be Tested/Reviewed?
Pick a jurisdiction with geocoding enabled and create an MSQ question.
Test existing geocoding functionality works without
enableV2MSQ.Testing with MSQ V2:
/adminand turn onenableV2MSQfor the jurisdiction/scriptRunner/migrateMultiselectDataToRefactorapplicationSelectionsfield [example body below]/applications/createisGeocodingVerifiedis set properly depending on the address submitted.Example body for the applicationsSelections field. Use prisma studio to collect the ids after running the script
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: