Skip to content

Conversation

@mcgarrye
Copy link
Collaborator

@mcgarrye mcgarrye commented Dec 23, 2025

This PR addresses #(5705)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Refactors the geocoding service to work with MSQ V2. The refactor allows reduced looping and requires less data be passed around.

This is pointing at PR #5701 as it follows changes to the application create function.

How Can This Be Tested/Reviewed?

Pick a jurisdiction with geocoding enabled and create an MSQ question.

Test existing geocoding functionality works without enableV2MSQ.

Testing with MSQ V2:

  • Start up prisma studio
  • Login to the partner site as a Super Admin
  • Go to /admin and turn on enableV2MSQ for the jurisdiction
  • Go to the api page and run /scriptRunner/migrateMultiselectDataToRefactor
  • Make sure a listing in the desired jurisdiction has the earlier created MSQ question
  • Adjust the copied payload for submission by populating the applicationSelections field [example body below]
  • Submit through the api using /applications/create
  • Call the GET on the returned id and verify that isGeocodingVerified is set properly depending on the address submitted.

Example body for the applicationsSelections field. Use prisma studio to collect the ids after running the script

"applicationSelections": [
    {
        "hasOptedOut": null,
        "multiselectQuestion": {"id": "3e4c5476-8767-4bfa-b308-f5a1640ed06e"},
        "selections": [
            {
                "addressHolderAddress": {
                    "placeName": null,
                    "city": "Napa",
                    "county": null,
                    "state": "CA",
                    "street": "2024 1st St",
                    "street2": "",
                    "zipCode": "94559",
                    "latitude": null,
                    "longitude": null
                },
                "addressHolderName": null,
                "addressHolderRelationship": null,
                "isGeocodingVerified": null,
                "multiselectOption": {"id": "82df263e-6d74-4b67-b834-9a67b83afbff"}
            }
        ]
    }
]

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye added 1 review needed Requires 1 more review before ready to merge questions and removed questions labels Dec 23, 2025
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The true and false path look good there is just a third path that we need to figure out how to handle with this new setup

Base automatically changed from 5147/msq-refactor-application-service to main January 6, 2026 17:12
@mcgarrye mcgarrye changed the base branch from main to 5147/msq-refactor-application-service January 6, 2026 17:16
@mcgarrye mcgarrye changed the base branch from 5147/msq-refactor-application-service to main January 6, 2026 17:16
@mcgarrye mcgarrye changed the base branch from main to 5147/msq-refactor-application-service January 6, 2026 17:17
@mcgarrye mcgarrye changed the base branch from 5147/msq-refactor-application-service to main January 6, 2026 19:25
@mcgarrye mcgarrye requested a review from ludtkemorgan January 6, 2026 19:25
@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-flagly canceled.

Name Link
🔨 Latest commit d2138a6
🔍 Latest deploy log https://app.netlify.com/projects/bloom-flagly/deploys/695e7f30bb90030008052e87

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for bloom-angelopolis canceled.

Name Link
🔨 Latest commit d2138a6
🔍 Latest deploy log https://app.netlify.com/projects/bloom-angelopolis/deploys/695e7f3036f2060008ef4c0b

@netlify
Copy link

netlify bot commented Jan 6, 2026

Deploy Preview for partners-bloom-dev ready!

Name Link
🔨 Latest commit d2138a6
🔍 Latest deploy log https://app.netlify.com/projects/partners-bloom-dev/deploys/695e7f301f021e00081f9745
😎 Deploy Preview https://deploy-preview-5714--partners-bloom-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1 review needed Requires 1 more review before ready to merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants