-
Notifications
You must be signed in to change notification settings - Fork 39
feat: geocoding refactor #5714
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: geocoding refactor #5714
Conversation
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The true and false path look good there is just a third path that we need to figure out how to handle with this new setup
…factor-geocoding-service
✅ Deploy Preview for bloom-flagly ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-angelopolis canceled.
|
✅ Deploy Preview for partners-bloom-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ludtkemorgan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding that test!
✅ Deploy Preview for bloom-lakeview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-exygy-dev ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for bloom-public-seeds ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This PR addresses #(5705)
Description
Refactors the geocoding service to work with MSQ V2. The refactor allows reduced looping and requires less data be passed around.
This is pointing at PR #5701 as it follows changes to the application create function.
How Can This Be Tested/Reviewed?
Pick a jurisdiction with geocoding enabled and create an MSQ question.
Test existing geocoding functionality works without
enableV2MSQ.Testing with MSQ V2:
/adminand turn onenableV2MSQfor the jurisdiction/scriptRunner/migrateMultiselectDataToRefactorapplicationSelectionsfield [example body below]/applications/createisGeocodingVerifiedis set properly depending on the address submitted.Example body for the applicationsSelections field. Use prisma studio to collect the ids after running the script
Author Checklist:
yarn generate:clientand/or created a migration when requiredReview Process: