fix: add smoking policy radio

api/prisma/seed-staging.ts

@@ -175,6 +175,7 @@ export const stagingSeed = async (
         FeatureFlagEnum.enableNeighborhoodAmenitiesDropdown,
         FeatureFlagEnum.enableProperties,
         FeatureFlagEnum.enableReferralQuestionUnits,
+        FeatureFlagEnum.enableSmokingPolicyRadio,
       ],
       visibleNeighborhoodAmenities: [
         NeighborhoodAmenitiesEnum.groceryStores,

api/src/enums/feature-flags/feature-flags-enum.ts

@@ -40,6 +40,7 @@ export enum FeatureFlagEnum {
   enableRegions = 'enableRegions',
   enableSection8Question = 'enableSection8Question',
   enableSingleUseCode = 'enableSingleUseCode',
+  enableSmokingPolicyRadio = 'enableSmokingPolicyRadio',
   enableSupportAdmin = 'enableSupportAdmin',
   enableUnderConstructionHome = 'enableUnderConstructionHome',
   enableUnitGroups = 'enableUnitGroups',
@@ -241,6 +242,11 @@ export const featureFlagMap: {
     description:
       'When true, the backend allows for logging into this jurisdiction using the single use code flow',
   },
+  {
+    name: FeatureFlagEnum.enableSmokingPolicyRadio,
+    description:
+      "When true, the listing 'Smoking policy' field is a radio group",
+  },
   {
     name: FeatureFlagEnum.enableSupportAdmin,
     description: 'When true, support admins can be created',

api/src/services/listing-csv-export.service.ts

@@ -861,10 +861,6 @@ export class ListingCsvExporterService implements CsvExporterServiceInterface {
           path: 'unitAmenities',
           label: 'Unit Amenities',
         },
-        {
-          path: 'smokingPolicy',
-          label: 'Smoking Policy',
-        },
         {
           path: 'petPolicy',
           label: 'Pets Policy',
@@ -873,6 +869,19 @@ export class ListingCsvExporterService implements CsvExporterServiceInterface {
           path: 'servicesOffered',
           label: 'Services Offered',
         },
+        {
+          path: 'smokingPolicy',
+          label: 'Smoking Policy',
+          format: (val: string): string => {
+            const enableSmokingPolicyRadio =
+              doAllJurisdictionHaveFeatureFlagSet(
+                user.jurisdictions,
+                FeatureFlagEnum.enableSmokingPolicyRadio,
+              );
+            if (!val) return enableSmokingPolicyRadio ? 'Policy unknown' : '';
+            return val;
+          },
+        },
       ],
     );
 

shared-helpers/src/types/backend-swagger.ts

@@ -8052,6 +8052,7 @@ export enum FeatureFlagEnum {
   "enableRegions" = "enableRegions",
   "enableSection8Question" = "enableSection8Question",
   "enableSingleUseCode" = "enableSingleUseCode",
+  "enableSmokingPolicyRadio" = "enableSmokingPolicyRadio",
   "enableSupportAdmin" = "enableSupportAdmin",
   "enableUnderConstructionHome" = "enableUnderConstructionHome",
   "enableUnitGroups" = "enableUnitGroups",

sites/partners/page_content/locale_overrides/general.json

@@ -454,6 +454,9 @@
   "listings.selectJurisdictionContent": "Once you create this listing, the jurisdiction cannot be changed.",
   "listings.selectPreferences": "Select preferences",
   "listings.selectPrograms": "Select programs",
+  "listings.smokingPolicyOptions.noSmokingAllowed": "No smoking allowed",
+  "listings.smokingPolicyOptions.smokingAllowed": "Smoking allowed",
+  "listings.smokingPolicyOptions.unknown": "Policy unknown",
   "listings.streetAddressOrPOBox": "Street address or PO box",
   "listings.totalListings": "Total listings",
   "listings.marketing": "Marketing",

sites/partners/src/components/listings/PaperListingDetails/sections/DetailBuildingFeatures.tsx

@@ -31,6 +31,11 @@ const DetailBuildingFeatures = () => {
     listing.jurisdictions.id
   )
 
+  const enableSmokingPolicyRadio = doJurisdictionsHaveFeatureFlagOn(
+    FeatureFlagEnum.enableSmokingPolicyRadio,
+    listing.jurisdictions.id
+  )
+
   return (
     <SectionWithGrid heading={t("listings.sections.buildingFeaturesTitle")} inset>
       <Grid.Row>
@@ -59,24 +64,26 @@ const DetailBuildingFeatures = () => {
 
       <Grid.Row>
         <Grid.Cell>
-          <FieldValue id="smokingPolicy" label={t("t.smokingPolicy")}>
-            {getDetailFieldString(listing.smokingPolicy)}
+          <FieldValue id="petPolicy" label={t("t.petsPolicy")}>
+            {getDetailFieldString(listing.petPolicy)}
           </FieldValue>
         </Grid.Cell>
       </Grid.Row>
 
       <Grid.Row>
         <Grid.Cell>
-          <FieldValue id="petPolicy" label={t("t.petsPolicy")}>
-            {getDetailFieldString(listing.petPolicy)}
+          <FieldValue id="servicesOffered" label={t("t.servicesOffered")}>
+            {getDetailFieldString(listing.servicesOffered)}
           </FieldValue>
         </Grid.Cell>
       </Grid.Row>
 
       <Grid.Row>
         <Grid.Cell>
-          <FieldValue id="servicesOffered" label={t("t.servicesOffered")}>
-            {getDetailFieldString(listing.servicesOffered)}
+          <FieldValue id="smokingPolicy" label={t("t.smokingPolicy")}>
+            {enableSmokingPolicyRadio
+              ? listing.smokingPolicy || t("listings.smokingPolicyOptions.unknown")
+              : getDetailFieldString(listing.smokingPolicy)}
           </FieldValue>
         </Grid.Cell>
       </Grid.Row>

sites/partners/src/components/listings/PaperListingForm/index.tsx

@@ -114,7 +114,13 @@ const ListingForm = ({
   setListingName,
   updateListing,
 }: ListingFormProps) => {
-  const defaultValues = editMode ? listing : formDefaults
+  const rawDefaultValues = editMode ? listing : formDefaults
+
+  const defaultValues: FormListing = {
+    ...rawDefaultValues,
+    smokingPolicy: rawDefaultValues?.smokingPolicy ?? "",
+  }
+
   const formMethods = useForm<FormListing>({
     defaultValues,
     mode: "onBlur",
@@ -585,6 +591,10 @@ const ListingForm = ({
                               FeatureFlagEnum.enableAccessibilityFeatures,
                               jurisdictionId
                             )}
+                            enableSmokingPolicyRadio={doJurisdictionsHaveFeatureFlagOn(
+                              FeatureFlagEnum.enableSmokingPolicyRadio,
+                              jurisdictionId
+                            )}
                             requiredFields={requiredFields}
                           />
                           <NeighborhoodAmenities

sites/partners/src/components/listings/PaperListingForm/sections/BuildingFeatures.tsx

@@ -5,11 +5,12 @@ import { Grid } from "@bloom-housing/ui-seeds"
 import { listingFeatures } from "@bloom-housing/shared-helpers"
 import { ListingFeatures } from "@bloom-housing/shared-helpers/src/types/backend-swagger"
 import SectionWithGrid from "../../../shared/SectionWithGrid"
-import { defaultFieldProps } from "../../../../lib/helpers"
+import { defaultFieldProps, getLabel } from "../../../../lib/helpers"
 import styles from "../ListingForm.module.scss"
 
 type BuildingFeaturesProps = {
   enableAccessibilityFeatures?: boolean
+  enableSmokingPolicyRadio?: boolean
   existingFeatures: ListingFeatures
   requiredFields: string[]
 }
@@ -91,23 +92,6 @@ const BuildingFeatures = (props: BuildingFeaturesProps) => {
               )}
             />
           </Grid.Cell>
-          <Grid.Cell>
-            <Textarea
-              fullWidth={true}
-              placeholder={""}
-              register={register}
-              maxLength={600}
-              {...defaultFieldProps(
-                "smokingPolicy",
-                t("t.smokingPolicy"),
-                props.requiredFields,
-                errors,
-                clearErrors
-              )}
-            />
-          </Grid.Cell>
-        </Grid.Row>
-        <Grid.Row>
           <Grid.Cell>
             <Textarea
               fullWidth={true}
@@ -123,6 +107,8 @@ const BuildingFeatures = (props: BuildingFeaturesProps) => {
               )}
             />
           </Grid.Cell>
+        </Grid.Row>
+        <Grid.Row>
           <Grid.Cell>
             <Textarea
               fullWidth={true}
@@ -138,6 +124,54 @@ const BuildingFeatures = (props: BuildingFeaturesProps) => {
               )}
             />
           </Grid.Cell>
+          <Grid.Cell>
+            {props.enableSmokingPolicyRadio ? (
+              <FieldGroup
+                type="radio"
+                name="smokingPolicy"
+                groupLabel={getLabel("smokingPolicy", props.requiredFields, t("t.smokingPolicy"))}
+                register={register}
+                fields={[
+                  {
+                    id: "smokingPolicyNoSmokingAllowed",
+                    dataTestId: "smokingPolicy.noSmokingAllowed",
+                    label: t("listings.smokingPolicyOptions.noSmokingAllowed"),
+                    value: "No smoking allowed",
+                  },
+                  {
+                    id: "smokingPolicySmokingAllowed",
+                    dataTestId: "smokingPolicy.smokingAllowed",
+                    label: t("listings.smokingPolicyOptions.smokingAllowed"),
+                    value: "Smoking allowed",
+                  },
+                  {
+                    id: "smokingPolicyUnknown",
+                    dataTestId: "smokingPolicy.unknown",
+                    label: t("listings.smokingPolicyOptions.unknown"),
+                    value: "",
+                    inputProps: {
+                      //without it empty value is overwritten by id
+                      defaultValue: "",
+                    },
+                  },
+                ]}
+              />
+            ) : (
+              <Textarea
+                fullWidth={true}
+                placeholder={""}
+                register={register}
+                maxLength={600}
+                {...defaultFieldProps(
+                  "smokingPolicy",
+                  t("t.smokingPolicy"),
+                  props.requiredFields,
+                  errors,
+                  clearErrors
+                )}
+              />
+            )}
+          </Grid.Cell>
         </Grid.Row>
         {!props.enableAccessibilityFeatures ? null : (
           <Grid.Row>

sites/public/src/components/listing/ListingViewSeedsHelpers.tsx

@@ -185,9 +185,6 @@ export const getFeatures = (
   if (listing.yearBuilt) {
     features.push({ heading: t("t.built"), subheading: listing.yearBuilt })
   }
-  if (listing.smokingPolicy) {
-    features.push({ heading: t("t.smokingPolicy"), subheading: listing.smokingPolicy })
-  }
   if (listing.petPolicy) {
     features.push({ heading: t("t.petsPolicy"), subheading: listing.petPolicy })
   }
@@ -200,6 +197,9 @@ export const getFeatures = (
   if (listing.servicesOffered) {
     features.push({ heading: t("t.servicesOffered"), subheading: listing.servicesOffered })
   }
+  if (listing.smokingPolicy) {
+    features.push({ heading: t("t.smokingPolicy"), subheading: listing.smokingPolicy })
+  }
   const accessibilityFeatures = getAccessibilityFeatures(listing)
   const enableAccessibilityFeatures = jurisdiction?.featureFlags?.some(
     (flag) => flag.name === "enableAccessibilityFeatures" && flag.active